Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bunch of misspellings #170

Merged
merged 4 commits into from
Mar 25, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/main/java/frc/robot/Constants.java
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public static final class Drive {
/** The max speed for the robot when not sprinting (in m/s) */
public static final double MAX_NORMAL_SPEED = 2;

/** The max angular speed (in randians) for the robot when not sprinting */
/** The max angular speed (in radians) for the robot when not sprinting */
public static final double MAX_NORMAL_ANGULAR_SPEED = 2 * Math.PI;

/** The Translation Drive PID for the robot. */
Expand All @@ -114,8 +114,9 @@ public static final class Drive {
public static final PIDConstants ROTATION_DRIVE_PID = new PIDConstants(1.0, 0.0, 0.0);
}

/** Holds constants specfically related to autonomous. */
public static final class Auto {
/** Holds constants specifically related to autonomous. */
public static class Auto {

/** The number of meters per second that we want to move forward during the taxi auto */
public static final double TAXI_AUTO_METERS_PER_SECOND = 1.0;

Expand Down Expand Up @@ -160,11 +161,11 @@ public static final class Intake {
public static final IdleMode INTAKE_MOTOR_IDLE_MODE = IdleMode.kBrake;
}

/** Holds contstants for the Limelights. */
/** Holds constants for the Limelights. */
public static final class Limelight {
/** Constants for aiming Limelight. */
public static final class AimingLimelight {
/** Our name in the networktables for the limelight */
/** Our name in the network tables for the limelight */
public static final String LIMELIGHT_NAME = "limelight";

/** The number of degrees the Limelight is mounted back from perfectly vertical */
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/frc/robot/Controllers.java
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ public static void configureKeybinds(Keymap keymap) {
break;
default:
throw new IllegalArgumentException(
"configureKeybinds() recieved an illegal enum constant argument");
"configureKeybinds() received an illegal enum constant argument");
}
}

Expand Down Expand Up @@ -207,7 +207,7 @@ public static double getControllerAxis(
return controller.getRightY();
default:
throw new IllegalArgumentException(
"getControllerAxis() recieved an illegal enum constant argument");
"getControllerAxis() received an illegal enum constant argument");
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/frc/robot/commands/mailbox/DeindexNote.java
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public void execute() {
if (mailbox.getLimitSwitch()) {
intake.runIntake();
}
/* This else isn't neccessary, just advised for safety. If it interferes with anything, feel
/* This else isn't necessary, just advised for safety. If it interferes with anything, feel
free to remove it. */
else {
intake.stop();
Expand Down
12 changes: 6 additions & 6 deletions src/main/java/frc/robot/subsystems/Drive.java
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public class Drive extends SubsystemBase {
/** Creates a new Drive. */
public Drive() {
/* Try-catch because otherwise the compiler tries to anticipate runtime errors and throws a
* compiletime error for a missing file even though it shouldn't
* comp-time error for a missing file even though it shouldn't
*/
try {
drive =
Expand Down Expand Up @@ -92,7 +92,7 @@ public Drive() {
* Drives the robot in either field relative or robot relative.
*
* @param translation {@link Translation2d} that represents the commanded robot velocities on the
* x and y axes. Front-left postitive. Reletive to the field.
* x and y axes. Front-left positive. Relative to the field.
* @param z Robot angular velocity around the z-axis in radians per second. Counter-clockwise is
* positive.
* @param isFieldOriented If the robot should either drive field oriented or robot oriented.
Expand Down Expand Up @@ -122,18 +122,18 @@ public void zeroGyro() {
}

/**
* Gets the maximum speed the robot chassis can acheive in m/s.
* Gets the maximum speed the robot chassis can achieve in m/s.
*
* @return Maximum speed the robot chassis can acheive in m/s.
* @return Maximum speed the robot chassis can achieve in m/s.
*/
public double getMaximumSpeed() {
return Math.min(drive.getMaximumVelocity(), Constants.Drive.MAX_SPEED);
}

/**
* Gets the maximum angular speed the robot chassis can acheive in rad/s.
* Gets the maximum angular speed the robot chassis can achieve in rad/s.
*
* @return Maximum angular speed the robot chassis can acheive in rad/s.
* @return Maximum angular speed the robot chassis can achieve in rad/s.
*/
public double getMaximumAngularSpeed() {
return Math.min(drive.getMaximumAngularVelocity(), Constants.Drive.MAX_ANGULAR_SPEED);
Expand Down
10 changes: 5 additions & 5 deletions src/main/java/frc/robot/subsystems/Limelight.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@
/** Subsystem for the Limelight 2+ that we use for vision. */
public class Limelight extends SubsystemBase {

/* variable chaingun, I promise we use all of these */
/* variable chain-gun, I promise we use all of these */
private DoubleSubscriber tvSubscriber, txSubscriber, tySubscriber, taSubscriber;
/* See https://docs.limelightvision.io/en/latest/apriltags_in_3d.html#robot-localization-botpose-and-megatag
* to understand what the heck the different indices in this array mean
*/
private DoubleArraySubscriber botposSubscriber;
private DoubleSubscriber pipelineSubcriber;
private DoubleSubscriber pipelineSubscriber;
private DoublePublisher pipelinePublisher;
private String name;

Expand All @@ -57,7 +57,7 @@ public Limelight(String name) {
taSubscriber = NetworkTableInstance.getDefault().getDoubleTopic(fmtPath("ta")).subscribe(0.0);
DoubleTopic pipelineTopic =
NetworkTableInstance.getDefault().getDoubleTopic(fmtPath("pipeline"));
this.pipelineSubcriber = pipelineTopic.subscribe(0.0);
this.pipelineSubscriber = pipelineTopic.subscribe(0.0);
this.pipelinePublisher = pipelineTopic.publish();
double[] defaultBotpos = {0.0, 0.0, 0.0, 0.0, 0.0, 0.0};
botposSubscriber =
Expand All @@ -73,7 +73,7 @@ public Limelight(String name) {
limelightHasTarget = Shuffleboard.getTab("Driver").add(name + "has target", false).getEntry();
}

/* now its time for getter method chaingun, which I have to write manually because VS Code */
/* now its time for getter method chain gun, which I have to write manually because VS Code */
quackitsquinn marked this conversation as resolved.
Show resolved Hide resolved

/**
* Returns whether the Limelight has a valid target.
Expand Down Expand Up @@ -149,7 +149,7 @@ public Pose2d getBotpose2d() {
* @return the current Limelight pipeline number.
*/
public double getLimelightPipeline() {
return pipelineSubcriber.get();
return pipelineSubscriber.get();
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public class MailboxBelts extends SubsystemBase {
private CANSparkMax upperBeltMotor;
private CANSparkMax lowerBeltMotor;

/** Constructer for MailboxBelts subsystem */
/** Constructor for MailboxBelts subsystem */
public MailboxBelts() {
upperBeltMotor =
new CANSparkMax(Constants.MailboxBelts.UPPER_BELT_MOTOR_ID, MotorType.kBrushless);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import frc.robot.Constants;

/**
* Represents the pistons that raise the Mailbox, which is the system that outputs gamepieces from
* Represents the pistons that raise the Mailbox, which is the system that outputs game pieces from
* our robot
*/
public class MailboxPneumatics extends SubsystemBase {
Expand Down
Loading