Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressable rgb #176

Merged
merged 37 commits into from
Apr 4, 2024
Merged

Addressable rgb #176

merged 37 commits into from
Apr 4, 2024

Conversation

quackitsquinn
Copy link
Member

closes #163

This should probably be tested on the robot before merged, but I figured id make the PR so the code review part can be finished.

@quackitsquinn
add AddressableLightStrip
ed6ba29
@quackitsquinn
add some helper methods to AddressableLightStrip
2490a2d
@quackitsquinn
add RobotDisabledLights command
d5fea9b
@quackitsquinn
Finish RobotDisabledLights
6c505c1
@quackitsquinn
Merge remote-tracking branch 'origin/main' into addressable-rgb
186f612
@quackitsquinn
typos and bugfix
d8a707a
@quackitsquinn
Move constants and make the disable lights run
4446c25
@quackitsquinn
Rename RobotDisabledLights to DisabledLights
887729d
@quackitsquinn
thank you vscode for not refactoring
bdd1c51
@quackitsquinn
Merge branch 'main' into addressable-rgb
25c2535
@quackitsquinn
Merge branch 'main' into addressable-rgb
bf9897e
@quackitsquinn
update light count
84f54c0
@quackitsquinn
add enabled lights and fixed disable lights
089b3ca
@quackitsquinn
add a quick and dirty ish rainbow implementation
19d8c2d
@quackitsquinn
Merge remote-tracking branch 'origin/main' into addressable-rgb
0364287
@quackitsquinn
Merge branch 'main' into addressable-rgb
79383ed
@quackitsquinn
clean up enable light code some
805f266
@quackitsquinn
add color fading
6a3dcd9 
took way too long to debug
@quackitsquinn
remove weird unicode character that randomly appeared
189f888
@quackitsquinn
led code cleanup
5b63948
@quackitsquinn
Remove test thing
c0d5fb1
@quackitsquinn
add getLength to AddressableLightStrip
b0f1604
@quackitsquinn
add boot sequence
5f67dcc
@quackitsquinn
refactor constant name
1eb33f1
@quackitsquinn
add setFadeSpeed and resetFadeSpeed
03f7409
@quackitsquinn
some (hopefully) final tweaks
0841813 
ive been working on this for 1 1/2 hours i need sleep
@quackitsquinn
fix weird unicode character AGAIN
2cc0b8f 
also actually its been closer to 3 hours
@quackitsquinn quackitsquinn added the needs testing The features present require testing. label Apr 1, 2024
@quackitsquinn
remove unnecessary thing
7e7d8fc 
im predicting that i wont need a "add "unnecessary" thing back" commit
@willitcode
Copy link
Member

Will review later. I've got bigger fish to fry for now.

AraReighard
AraReighard requested changes Apr 1, 2024
View reviewed changes
Copy link
Member

@AraReighard AraReighard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sowwy

src/main/java/frc/robot/RobotContainer.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/lightstrip/DisabledLight.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/lightstrip/EnabledLight.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/lightstrip/NodeLight.java Outdated Show resolved Hide resolved
AraReighard
AraReighard requested changes Apr 1, 2024
View reviewed changes
Copy link
Member

@AraReighard AraReighard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javadoc

src/main/java/frc/robot/Constants.java Outdated Show resolved Hide resolved
AraReighard
AraReighard previously approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@AraReighard AraReighard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea looks fine

@willitcode willitcode removed the needs testing The features present require testing. label Apr 3, 2024
@willitcode
Copy link
Member

Pull requests never get labels.

willitcode
willitcode requested changes Apr 3, 2024
View reviewed changes
src/main/java/frc/robot/Constants.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/Constants.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/Constants.java Show resolved Hide resolved
src/main/java/frc/robot/Robot.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/RobotContainer.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/AddressableLightStrip.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/AddressableLightStrip.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/AddressableLightStrip.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/lightstrip/DisabledLight.java Show resolved Hide resolved
src/main/java/frc/robot/commands/lightstrip/NodeLight.java Outdated Show resolved Hide resolved
@quackitsquinn quackitsquinn merged commit a542d81 into main Apr 4, 2024
2 checks passed
@quackitsquinn quackitsquinn deleted the addressable-rgb branch April 4, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willitcode willitcode willitcode approved these changes

@AraReighard AraReighard AraReighard left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AddressableLEDs
3 participants
@quackitsquinn @willitcode @AraReighard