Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pneumatics Code to Use Spikes #178

Merged
merged 8 commits into from
Apr 4, 2024
Merged

Conversation

quackitsquinn
Copy link
Member

@quackitsquinn quackitsquinn commented Apr 3, 2024

Updates the code for pneumatics to use Spike relays instead of a PCM. Closes #177

@willitcode
Copy link
Member

Tag the issue number

Copy link
Member

@willitcode willitcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one minor comment. @Berdenson please review for any JavaDoc nonsense that I missed

src/main/java/frc/robot/Constants.java Outdated Show resolved Hide resolved
Copy link
Member

@AraReighard AraReighard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javadocccccc

src/main/java/frc/robot/RobotContainer.java Show resolved Hide resolved
src/main/java/frc/robot/RobotContainer.java Show resolved Hide resolved
Copy link
Member

@AraReighard AraReighard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea looks good

@quackitsquinn quackitsquinn merged commit cb6ca62 into main Apr 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spike H-Bridge based pneumatics
3 participants