Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javadoc everything #18

Merged
merged 7 commits into from
Jan 25, 2024
Merged

Javadoc everything #18

merged 7 commits into from
Jan 25, 2024

Conversation

MarissaKoglesby
Copy link
Contributor

Closes #10

quackitsquinn
quackitsquinn requested changes Jan 24, 2024
View reviewed changes
Copy link
Member

@quackitsquinn quackitsquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some Javadoc needs to be added to both Robot and Main that say something along the lines of "hey this is almost certainly not where you put code put it in RobotContainer" so no one gets confused.

@willitcode
Copy link
Member

I think some Javadoc needs to be added to both Robot and Main that say something along the lines of "hey this is almost certainly not where you put code put it in RobotContainer" so no one gets confused.

I would do this as a regular comment and not JavaDoc, since Robot (at the very least) will inherit JavaDoc from RobotBase

@willitcode
Copy link
Member

@Jack-Haefele hey btw they're double solenoids, not single. Elec just told us

@quackitsquinn quackitsquinn self-requested a review January 25, 2024 00:00
quackitsquinn
quackitsquinn approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@quackitsquinn quackitsquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@quackitsquinn quackitsquinn merged commit 2f34df5 into main Jan 25, 2024
2 checks passed
@quackitsquinn quackitsquinn deleted the javadoc-everything branch January 25, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quackitsquinn quackitsquinn quackitsquinn approved these changes

@AraReighard AraReighard Awaiting requested review from AraReighard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JavaDoc everything
3 participants
@MarissaKoglesby @willitcode @quackitsquinn