Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for gzip transcoding #924

Merged
merged 11 commits into from
Sep 21, 2022
Merged

Add support for gzip transcoding #924

merged 11 commits into from
Sep 21, 2022

Conversation

le0pard
Copy link
Contributor

@le0pard le0pard commented Sep 20, 2022 •
edited by fsouza
Loading

@le0pard
Copy link
Contributor Author

le0pard commented Sep 20, 2022 

Error: fatal: unable to access 'https://github.com/fsouza/fake-gcs-server/': The requested URL returned error: 429

Looks like need retry test suite - error from github git.

fsouza
fsouza reviewed Sep 21, 2022
View reviewed changes
Copy link
Owner

@fsouza fsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for contributing!

fakestorage/upload.go
obj := Object{
ObjectAttrs: ObjectAttrs{
BucketName: bucketName,
Name: objName,
ContentType: metadata.ContentType,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the fix for #532?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope so :)

fakestorage/object.go Outdated Show resolved Hide resolved
fakestorage/object.go Outdated Show resolved Hide resolved
@le0pard le0pard requested a review from fsouza September 21, 2022 07:01
@fsouza
Copy link
Owner

fsouza commented Sep 21, 2022

Thanks for contributing!

@fsouza fsouza merged commit 5ab869f into fsouza:main Sep 21, 2022
@otherguy otherguy mentioned this pull request Mar 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsouza fsouza fsouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resumable uploads don't set content-type
2 participants
@le0pard @fsouza