Bump to net8 and drop net45, fable3, netstandard #604
Conversation
| @@ -199,7 +199,7 @@ type Parse with | |||
|
|
|||
| static member inline Parse (_: ^R , _: Default2) : string -> ^R = Parse.InvokeOnInstance | |||
|
|
|||
| #if NET7_0 | |||
| #if NET7_0_OR_GREATER | |||
We should remove the old fable versions as well. |
wallymathieu
changed the title
wallymathieu
changed the title
| @@ -28,7 +28,7 @@ type Apply = | |||
| #if !FABLE_COMPILER | |||
| static member ``<*>`` (struct (f: Task<_> , x: Task<'T> ), _output: Task<'U> , [<Optional>]_mthd: Apply) = Task.apply f x : Task<'U> | |||
| #endif | |||
| #if !NET45 && !NETSTANDARD2_0 && !FABLE_COMPILER | |||
| #if !FABLE_COMPILER | |||
There was a problem hiding this comment.
Is this needed since most of the file is excluded for Fable?
|
|
||
| static member Map ((x: Lazy<_> , f: 'T->'U), _mthd: Map) = Lazy.map f x | ||
| #if !FABLE_COMPILER | ||
| static member Map ((x: Task<'T> , f: 'T->'U), _mthd: Map) = Task.map f x : Task<'U> | ||
| #endif | ||
| #if !NET45 && !NETSTANDARD2_0 && !FABLE_COMPILER | ||
| #if !FABLE_COMPILER |
There was a problem hiding this comment.
Is this needed since it is in a block that is already excluded from Fable?
There was a problem hiding this comment.
We can try removing it, once everything is green I guess.
| <Platforms>AnyCPU</Platforms> | ||
| <LangVersion>8.0</LangVersion> | ||
| <LangVersion Condition=" '$(Configuration)' == 'Fable' OR '$(Configuration)' == 'Fable3' ">6.0</LangVersion> | ||
| <LangVersion Condition=" '$(Configuration)' == 'Fable' ">6.0</LangVersion> |
There was a problem hiding this comment.
What should the language level for Fable4 be?
There was a problem hiding this comment.
I think we decided to drop support for Fable 3, but let's do it in another PR.
There was a problem hiding this comment.
I already did drop it in this PR. Note the removal of a lot of ifdefs...
There was a problem hiding this comment.
We can cherry-pick those commits out of this PR though.
|
Many thanks @cannorin for the help! |
Drop net45 and bump to net8. Note that in the v1 branches net45 is still one of the target framework.
This is related to #578 and #577