Default to raw bytes for vlr types #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenCurran98
requested review from
n6171028,
MeganDawson42,
mazadbakht,
zqiaofugro and
i-kieu
Signed-off-by: BenCurran98 <b.curran@fugro.com>
Signed-off-by: BenCurran98 <b.curran@fugro.com>
BenCurran98
force-pushed
the
VLRRegisterDefault
branch
from
f4e267d
to
c8d17f3
Compare
MeganDawson42
approved these changes
Oct 28, 2024
n6171028
approved these changes
Oct 28, 2024
i-kieu
approved these changes
Oct 28, 2024
mazadbakht
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read raw bytes if user + record ID combo not registered
Description
This was a bug introduced in the recent internal VLR changes where an error is thrown if the provided combination of VLR user and record IDs haven't been registered. This is incorrect, as the default behaviour for an unregistered pair should be just to read the raw bytes. I've updated this and added some explicit tests for handling it
Types of Changes
Review
List of tasks the reviewer must do to review the PR