Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(package): migrate to ng11 #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m7mdbadawy
Copy link

updating deps and updating version in all projects

BREAKING CHANGE: using ng11

** PR Checklist
Please check if your PR fulfills the following requirements:

** PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

** What is the current behavior?

The current build uses angular 9

Issue Number: N/A

** What is the new behavior?

it should support angular 11

** Does this PR introduce a breaking change?

[x] Yes
[ ] No

This uses angular 11 deps and compiler and should be used with angular 11

** Other information

updating deps and updating version in all projects

BREAKING CHANGE: using ng11
@m7mdbadawy m7mdbadawy requested a review from fulls1z3 as a code owner April 11, 2021 13:08
@ghost
Copy link

ghost commented Apr 11, 2021

Sider detected 2 warnings on analyzing the commit 449ca26.

We recommend fixing them as possible by updating the dependencies, configuring the analysis tool, configuring sider.yml, turning off unused tools, and so on.

If you have problems or questions still, feel free to ask us via chat. 💬


You can turn off this notification if you don't want to receive it from now on.

@fulls1z3
Copy link
Owner

fulls1z3 commented Jul 8, 2021

@m7mdbadawy need help with these PR's, especially with ng-packagr is failing. once done aim is first to ng 10 and then eventually to ng11 and ng12 (supporting all intermediate versions)

and finally we're showcasing it on fulls1z3/universal#755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants