Merge pull request #4 from funzin/fix-regexp

Fix bug not converted when the image title contains space

manifest.json

@@ -1,7 +1,7 @@
 {
   "name": "ImgConverter for Github",
   "short_name": "ImgConverter",
-  "version": "0.1",
+  "version": "0.1.1",
   "description": "ImgConverter converts from image of markdown notation to to img tag",
   "manifest_version": 2,
   "permissions": [

package.json

@@ -1,6 +1,6 @@
 {
   "name": "imgconverter",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "description": "ImgConverter converts from image of markdown notation to to img tag",
   "main": "karma.conf.js",
   "dependencies": {

spec/js/convert-to-img-tag-spec.js

@@ -16,6 +16,19 @@ describe("convertToImgTag", function(){
     })
   }) 
 
+  describe('when image title contains space', function () {
+    beforeEach(function () {
+      text = "hogehoge![hello world](https://user-images.githubusercontent.com/test0.png)\n \
+              hogehoge![hello world](https://user-images.githubusercontent.com/test1.png)"
+      result = convertToImgTag(text, "")
+    })
+    it('should return replaced text', function () {
+      text = "hogehoge<img src=https://user-images.githubusercontent.com/test0.png >\n \
+              hogehoge<img src=https://user-images.githubusercontent.com/test1.png >"
+      expect(result).toEqual(text)
+    })
+  }) 
+
   describe('when text does not contain markdown image', function () {
     beforeEach(function () {
       text = "hogehoge\nhogehoge"

src/js/convert-to-img-tag.js

@@ -30,7 +30,7 @@ function convertToImgTag(text, params) {
 
 function createMarkdownImages(text, params) {
   let markdownImageArray = []
-  const results = text.match(/\!\[\S*\]\(https:\/\/user-images.githubusercontent.com\S+(jpg|jpeg|png)\)/gmi)
+  const results = text.match(/\!\[.*\]\(https:\/\/user-images.githubusercontent.com\S+(jpg|jpeg|png)\)/gmi)
   if (results == null) { return null}
 
   for (const mdImage of results) {