Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print layout with no maps #587

Merged
merged 8 commits into from
Mar 8, 2024
Merged

Print layout with no maps #587

merged 8 commits into from
Mar 8, 2024

Conversation

volterra79
Copy link
Member

@volterra79 volterra79 commented Feb 27, 2024

Closes: #586

Before

Screenshot from 2024-02-27 09-59-51

After: disable scale and rotation

Screenshot from 2024-02-27 10-04-20

@volterra79 volterra79 added bug Something isn't working backport to v3.9.x labels Feb 27, 2024
@volterra79 volterra79 added this to the v3.10 milestone Feb 27, 2024
@volterra79 volterra79 self-assigned this Feb 27, 2024
Copy link
Collaborator

@Raruto Raruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volterra79 I'll open a new PR with a full rewrite of the Print.vue file

volterra79 added a commit that referenced this pull request Feb 29, 2024
@volterra79 volterra79 merged commit 6755a76 into dev Mar 8, 2024
@volterra79 volterra79 deleted the issue_586 branch March 8, 2024 07:56
github-actions bot pushed a commit that referenced this pull request Mar 8, 2024
* clean code

* clean code

* remove space

* Disable scale an rotation when no maps are related to print setup

* Handle no maps case print layout

* refactor function `changeTemplate`

---------

Co-authored-by: Raruto <Raruto@users.noreply.github.com>
(cherry picked from commit 6755a76)
volterra79 added a commit that referenced this pull request Mar 22, 2024
* clean code

* clean code

* remove space

* Disable scale an rotation when no maps are related to print setup

* Handle no maps case print layout

* refactor function `changeTemplate`

---------

Co-authored-by: Raruto <Raruto@users.noreply.github.com>
(cherry picked from commit 6755a76)

Co-authored-by: Francesco Boccacci <boccacci.francesco@gmail.com>
Co-authored-by: Raruto <Raruto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to v3.9.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print layout with no maps
2 participants