Prevent HTTP request loop when using panoramic map control #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volterra79
changed the title
…ss to overview ol control to move it on left
Raruto
changed the title
Raruto
changed the title
|
@volterra79 however, I see a lot of requests while panning (perhaps should be throttled/debounced?):
|
@Rauto I'll check |
|
@Raruto it seems that it's no possible to throttled/debounced request image because its handled by internal OL code |
Raruto
approved these changes
Mar 14, 2024
wlorenzetti
approved these changes
Mar 18, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
* Comment * Clen code and fix ol.Observable OL object * Clean code * Clean code * Clean code * Clean code * Clean code * Fix overview map layers. In case of zoomhistory control, add left class to overview ol control to move it on left * remove lodash: `_.isNil` * reduce nested conditions * wrong context * If overview control is set, check map-control-lef-bottom and change style --------- Co-authored-by: Raruto <Raruto@users.noreply.github.com> (cherry picked from commit 8a415c0)
volterra79
added a commit
that referenced
this pull request
Mar 18, 2024
* Comment * Clen code and fix ol.Observable OL object * Clean code * Clean code * Clean code * Clean code * Clean code * Fix overview map layers. In case of zoomhistory control, add left class to overview ol control to move it on left * remove lodash: `_.isNil` * reduce nested conditions * wrong context * If overview control is set, check map-control-lef-bottom and change style --------- Co-authored-by: Raruto <Raruto@users.noreply.github.com> (cherry picked from commit 8a415c0) Co-authored-by: Francesco Boccacci <boccacci.francesco@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #596