-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ESLint 8.x #792
Conversation
Thanks very much for the report and draft PR.
I think we can work around this for now by:
context.report({
loc: {
start: {
column: 1,
line: 1,
},
},
message: `This rule cannot yet be supported for ESLint 8; you should either downgrade to ESLint 7 or disable this rule. The possibility for ESLint 8 support is being tracked at https://github.com/eslint/eslint/issues/14745`,
});
Am a bit preoccupied these days, but I should be able to review if you (or someone) could assist with those changes. |
b79ac1d
to
ea9e962
Compare
@brettz9 I think I did everything you mentioned. Let me know what you think of it! |
ea9e962
to
097c5d3
Compare
Thanks a lot. That mostly covered it. I've applied a few additional updates/fixes. Be sure to run I've disabled linting in CI (and lint-staged) until I checked the checkbox for @typescript-eslint/parser 5.0.0 as 5.0.0 is now released (and I guess the whole to-do for the parser is complete?). There is one remaining problem though... Despite getting this working fine locally, for our ESLint 7 CI tests, we're still getting an error related to |
BREAKING CHANGE: Requires ESLint@^7.0.0 || ^8.0.0
3891eff
to
4418543
Compare
Also updates devDeps., lints per latest canonical, resumes CI linting
Looks like we have one remaining task now of getting the CI Node 17 environment (for which I'd like this PR to add support) updating to Python >=3.6.0 |
7eab7ed
to
0c6db1a
Compare
b25bb34
to
604b400
Compare
🎉 This PR is included in version 37.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ESLint v8.0.0 is released 🎉
devDependency compatibility with ESLint 8:
@babel/eslint-parser
(Support ESLint 8.x babel/babel#13712)@babel/eslint-parser
babel/babel#13782v7.16.0
@typescript-eslint/parser
(Support for ESLint v8 typescript-eslint/typescript-eslint#3738)meta.docs.category
from rules typescript-eslint/typescript-eslint#3800PrivateIdentifier
typescript-eslint/typescript-eslint#3808v5.0.0
eslint-config-canonical
(Support ESLint 8.x eslint-config-canonical#32)v32.0.0
BREAKING CHANGE: Requires ESLint@^7.0.0 || ^8.0.0
Closes #791