Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused SetAsNiceMono #37

Merged
merged 1 commit into from
Jul 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions archive/group2.gd
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,6 @@ DeclareOperation( "ProjElWithFrobWithPSIsom",
[IsMatrix and IsFFECollColl, IsMapping, IsField,
IsGeneralMapping and IsSPGeneralMapping and IsOne] );
DeclareOperation( "ProjElsWithFrobWithPSIsom", [IsList, IsField] );
DeclareOperation( "SetAsNiceMono",
[IsProjGroupWithFrobWithPSIsom, IsGroupHomomorphism] );
DeclareAttribute( "Dimension", IsProjGroupWithFrobWithPSIsom );
DeclareProperty( "CanComputeActionOnPoints", IsProjGroupWithFrobWithPSIsom );
DeclareOperation( "CorrelationOfProjectiveSpace", [ IsList, IsField] );
Expand Down
11 changes: 0 additions & 11 deletions archive/group2.gi
Original file line number Diff line number Diff line change
Expand Up @@ -1084,17 +1084,6 @@ InstallMethod( CanComputeActionOnPoints,
fi;
end );

## A grep of SetAsNiceMono on all *.gi files gives only the InstallMethod( parts. (jdb 20/9/11), see also comment in
## group.gi

InstallMethod( SetAsNiceMono,
"for a projective group with Frobenius with pspace isomorphism and an action hom",
[IsProjGroupWithFrobWithPSIsom, IsGroupHomomorphism and IsInjective],
function( pg, a )
SetNiceMonomorphism(pg,a);
SetNiceObject(pg,Image(a));
end );

# CHECKED 20/09/11 jdb
#############################################################################
#O NiceMonomorphism( <pg> )
Expand Down
2 changes: 0 additions & 2 deletions doc/include/methods_inventory.txt
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,6 @@ M: Dimension, [IsProjectiveGroupWithFrob],
M: OneImmutable, # was [IsGroup and IsProjectiveGroupWithFrob], I think might be
M: CanComputeActionOnPoints, [IsProjectiveGroupWithFrob],
M: ActionOnAllProjPoints, [ IsProjectiveGroupWithFrob ],
M: SetAsNiceMono, [IsProjectiveGroupWithFrob, IsGroupHomomorphism and IsInjective],
M: NiceMonomorphism, [IsProjectivityGroup and CanComputeActionOnPoints and IsHandledByNiceMonomorphism],
M: NiceMonomorphism, [IsProjectiveGroupWithFrob and IsHandledByNiceMonomorphism],
M: NiceMonomorphism, [IsProjectiveGroupWithFrob and CanComputeActionOnPoints and IsHandledByNiceMonomorphism], 1,
Expand Down Expand Up @@ -417,7 +416,6 @@ M: Embedding, [IsProjectiveGroupWithFrob, IsProjGroupWithFrobWithPSIsom],
M: Dimension, [IsProjGroupWithFrobWithPSIsom],
M: ActionOnAllPointsHyperplanes, [ IsProjGroupWithFrobWithPSIsom ],
M: CanComputeActionOnPoints, [IsProjGroupWithFrobWithPSIsom],
M: SetAsNiceMono, [IsProjGroupWithFrobWithPSIsom, IsGroupHomomorphism and IsInjective],
M: NiceMonomorphism, [IsProjGroupWithFrobWithPSIsom and CanComputeActionOnPoints and IsHandledByNiceMonomorphism], 50,
M: NiceMonomorphism, [IsProjGroupWithFrobWithPSIsom and IsHandledByNiceMonomorphism], 50,
M: ViewObj, [IsProjGroupWithFrobWithPSIsom],
Expand Down
2 changes: 0 additions & 2 deletions doc/include/operations_inventory.txt
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ O: MatrixOfCollineation: [IsProjGrpElWithFrobandIsProjGrpElWithFrobRep]
O: MatrixOfCollineation: [IsProjGrpElandIsProjGrpElRep]
O: FieldAutomorphism: [IsProjGrpElWithFrobandIsProjGrpElWithFrobRep]
O: ActionOnAllProjPoints: [IsProjectiveGroupWithFrob]
O: SetAsNiceMono: [IsProjectiveGroupWithFrob, IsGroupHomomorphism]
O: CanonicalGramMatrix: [IsString, IsPosInt, IsField]
O: CanonicalQuadraticForm: [IsString, IsPosInt, IsField]
O: SOdesargues: [IsInt, IsPosInt, IsFieldandIsFinite]
Expand Down Expand Up @@ -168,7 +167,6 @@ O: ProjElWithFrobWithPSIsom: [IsMatrix and IsFFECollColl, IsMapping, IsFiel
O: ProjElWithFrobWithPSIsom: [IsMatrix and IsFFECollColl, IsMapping, IsField, IsStandardDualityOfProjectiveSpace]
O: ProjElWithFrobWithPSIsom: [IsMatrix and IsFFECollColl, IsMapping, IsField, IsGeneralMapping and IsSPGeneralMapping and IsOne]
O: ProjElsWithFrobWithPSIsom: [IsList, IsField]
O: SetAsNiceMono: [IsProjGroupWithFrobWithPSIsom, IsGroupHomomorphism]
O: CorrelationOfProjectiveSpace: [IsList, IsField]
O: CorrelationOfProjectiveSpace: [IsList, IsMapping, IsField]
O: CorrelationOfProjectiveSpace: [IsList, IsField, IsStandardDualityOfProjectiveSpace]
Expand Down
2 changes: 0 additions & 2 deletions lib/correlations.gd
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,6 @@ DeclareOperation( "ProjElWithFrobWithPSIsom",
[IsMatrix and IsFFECollColl, IsMapping, IsField,
IsGeneralMapping and IsSPGeneralMapping and IsOne] );
DeclareOperation( "ProjElsWithFrobWithPSIsom", [IsList, IsField] );
DeclareOperation( "SetAsNiceMono",
[IsProjGroupWithFrobWithPSIsom, IsGroupHomomorphism] );
DeclareAttribute( "Dimension", IsProjGroupWithFrobWithPSIsom );
DeclareProperty( "CanComputeActionOnPoints", IsProjGroupWithFrobWithPSIsom );

Expand Down
11 changes: 0 additions & 11 deletions lib/correlations.gi
Original file line number Diff line number Diff line change
Expand Up @@ -1425,17 +1425,6 @@ InstallMethod( CanComputeActionOnPoints,
fi;
end );

## A grep of SetAsNiceMono on all *.gi files gives only the InstallMethod( parts. (jdb 20/9/11), see also comment in
## group.gi

InstallMethod( SetAsNiceMono,
"for a projective group with Frobenius with pspace isomorphism and an action hom",
[IsProjGroupWithFrobWithPSIsom, IsGroupHomomorphism and IsInjective],
function( pg, a )
SetNiceMonomorphism(pg,a);
SetNiceObject(pg,Image(a));
end );

# CHECKED 20/09/11 jdb
#############################################################################
#O NiceMonomorphism( <pg> )
Expand Down
2 changes: 0 additions & 2 deletions lib/group.gd
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ DeclareGlobalFunction( "OnProjSubspacesNoFrob" );
# as a projective semilinear group (i.e. a collineation group), and for these
# groups we have the operations defined (ml 05/11/2012)
#DeclareOperation( "ActionOnAllProjPoints", [IsProjectivityGroup] );
#DeclareOperation( "SetAsNiceMono", [IsProjectivityGroup, IsGroupHomomorphism] );
#DeclareAttribute( "Dimension", IsProjectivityGroup );
#DeclareProperty( "CanComputeActionOnPoints", IsProjectivityGroup );

Expand All @@ -158,7 +157,6 @@ DeclareGlobalFunction( "OnProjPointsWithFrob" );
DeclareGlobalFunction( "OnProjSubspacesWithFrob" );

DeclareOperation( "ActionOnAllProjPoints", [IsProjectiveGroupWithFrob] );
DeclareOperation( "SetAsNiceMono", [IsProjectiveGroupWithFrob, IsGroupHomomorphism] );

DeclareAttribute( "Dimension", IsProjectiveGroupWithFrob );
DeclareProperty( "CanComputeActionOnPoints", IsProjectiveGroupWithFrob );
Expand Down
20 changes: 0 additions & 20 deletions lib/group.gi
Original file line number Diff line number Diff line change
Expand Up @@ -2154,26 +2154,6 @@ InstallGlobalFunction( NiceMonomorphismByDomain,
return iso;
end );

## Is this operation ever used? I think it obselete (JB: 26/09/08)
## John is probably right. A grep of SetAsNiceMono on all *.gi files gives only the InstallMethod( parts. (jdb 6/9/11).

# ml 07/11/2012: I have taken out the view, print and display methods
# for projectivity groups, since these are also collineation groups in FinInG
#InstallMethod( SetAsNiceMono, "for a projective group and an action hom",
# [IsProjectivityGroup, IsGroupHomomorphism and IsInjective],
# function( pg, a )
# SetNiceMonomorphism(pg,a);
# SetNiceObject(pg,Image(a));
# end );

InstallMethod( SetAsNiceMono,
"for a projective collineation group and an action hom",
[IsProjectiveGroupWithFrob, IsGroupHomomorphism and IsInjective],
function( pg, a )
SetNiceMonomorphism(pg,a);
SetNiceObject(pg,Image(a));
end );

# CHECKED 6/09/11 jdb
# cvec change 19/3/14
#############################################################################
Expand Down
3 changes: 0 additions & 3 deletions old/group2old.gd
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,5 @@ DeclareOperation( "ProjElWithFrobWithVSIsom",

DeclareOperation( "ProjElsWithFrobWithVSIsom", [IsList, IsField] );

DeclareOperation( "SetAsNiceMono",
[IsProjGroupWithFrobWithVSIsom, IsGroupHomomorphism] );

DeclareAttribute( "Dimension", IsProjGroupWithFrobWithVSIsom );
DeclareProperty( "CanComputeActionOnPoints", IsProjGroupWithFrobWithVSIsom );
8 changes: 0 additions & 8 deletions old/group2old.gi
Original file line number Diff line number Diff line change
Expand Up @@ -530,14 +530,6 @@ InstallMethod( ActionOnPointsHyperplanes,
return a;
end );

#InstallMethod( SetAsNiceMono,
# "for a projective group with Frobenius with vspace isomorphism and an action hom",
# [IsProjGroupWithFrobWithVSIsom, IsGroupHomomorphism and IsInjective],
# function( pg, a )
# SetNiceMonomorphism(pg,a);
# SetNiceObject(pg,Image(a));
# end );

#InstallMethod( NiceMonomorphism,
# "for a projective group with Frobenius with vspace isomorphism (feasible case)",
# [IsProjGroupWithFrobWithVSIsom and CanComputeActionOnPoints and
Expand Down