Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from old hashtable API to new API #41

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Switch from old hashtable API to new API #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/group.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2133,15 +2133,15 @@
# op the operation suitable for x and g
# It is guaranteed that g acts faithfully on the orbit.
local cand,gens,h,ht,i,iso,nr,pgens;
ht := NewHT(dom[1],Length(dom)*2);
ht := HTCreate(dom[1],rec(hashlen:=Length(dom)*2));

Check warning on line 2136 in lib/group.gi

View check run for this annotation

Codecov / codecov/patch

lib/group.gi#L2136 

Added line #L2136 was not covered by tests
for i in [1..Length(dom)] do
AddHT(ht,dom[i],i);
HTAdd(ht,dom[i],i);

Check warning on line 2138 in lib/group.gi

View check run for this annotation

Codecov / codecov/patch

lib/group.gi#L2138 

Added line #L2138 was not covered by tests
od;
pgens := [];
gens := GeneratorsOfGroup(g);
for i in [1..Length(gens)] do
Add(pgens,PermList( List([1..Length(dom)],
j->ValueHT(ht,op(dom[j],gens[i]))) ));
j->HTValue(ht,op(dom[j],gens[i]))) ));

Check warning on line 2144 in lib/group.gi

View check run for this annotation

Codecov / codecov/patch

lib/group.gi#L2144 

Added line #L2144 was not covered by tests
od;
h := GroupWithGenerators(pgens);
SetSize(h,Size(g));
Expand Down