Don't define Dimension for groups #43
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These attributes were misleading: the "dimension" of a groups is not normally defined as the dimension of some space it acts on (here: the dimension of the projective space plus 1 is used, i.e. "the size of the matrices" to quote a code comment).
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 47.61% 47.51% -0.11%
==========================================
Files 34 34
Lines 17906 17878 -28
==========================================
- Hits 8526 8494 -32
- Misses 9380 9384 +4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These attributes were misleading: the "dimension" of a groups is not normally defined as the dimension of some space it acts on (here: the dimension of the projective space plus 1 is used, i.e. "the size of the matrices" to quote a code comment).
I don't expect this PR will work in its current form (in particular I did not try to adjust any examples yet). It is of course also rather radical in that it just removes the code. It could instead just rename the attributes, or do something yet different. I mostly wanted this as a starting point for a possible discussion on what to do.