Switch to two argument version of ReadPackage #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The one argument form is not recommended, as it just has to split the string into two anyway, and the input looks like a path, but it isn't really, as the first part is a pacakge name, not a directory name...
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #16 +/- ##
=======================================
Coverage 56.03% 56.03%
=======================================
Files 19 19
Lines 1856 1856
=======================================
Hits 1040 1040
Misses 816 816 |
|
Thank you @fingolfin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The one argument form is not recommended, as it just has to split
the string into two anyway, and the input looks like a path, but
it isn't really, as the first part is a pacakge name, not a
directory name...