Remove second argument from STOP_TEST invocations (#5823)

This extra argument has been unused and optional for many years.

Also rename tst/testinstall/opers/IsInfiniteAbelianizationGroup.g
to .tst, it had the bad wrong extension since 2018.

benchmark/doublecoset/doublecoset1.tst

@@ -10,4 +10,4 @@ gap> dc:=DoubleCosetRepsAndSizes(g,u,u);;
 gap> Length(dc);Sum(dc,x->x[2])=Size(g);
 191
 true
-gap> STOP_TEST( "doublecoset1.tst", 1);
+gap> STOP_TEST("doublecoset1.tst");

benchmark/doublecoset/doublecoset2.tst

@@ -10,4 +10,4 @@ gap> dc:=DoubleCosetRepsAndSizes(g,u,u);;
 gap> Length(dc);Sum(dc,x->x[2])=Size(g);
 57
 true
-gap> STOP_TEST( "doublecoset2.tst", 1);
+gap> STOP_TEST("doublecoset2.tst");

benchmark/doublecoset/doublecoset3.tst

@@ -10,4 +10,4 @@ gap> dc:=DoubleCosetRepsAndSizes(g,u,u);;
 gap> Length(dc);Sum(dc,x->x[2])=Size(g);
 913
 true
-gap> STOP_TEST( "doublecoset3.tst", 1);
+gap> STOP_TEST("doublecoset3.tst");

tst/extractmanuals.g

@@ -35,7 +35,7 @@ WriteExamplesTst := function(directory, meta)
                    AppendTo(output, "\n");
                 fi;
             od;
-            AppendTo(output, "\n\n\ngap> STOP_TEST(\"", chname, "\", 0);");
+            AppendTo(output, "\n\n\ngap> STOP_TEST(\"", chname, "\");");
         fi;
     od;
     return chapterfiles;

tst/testbugfix/2018-12-06-GroupWithGenerators.tst

@@ -5,4 +5,4 @@ gap> GroupByGenerators( Group( (1,2) ) );
 Group([ (), (1,2) ])
 gap> GroupWithGenerators( Group( (1,2) ) );
 Group([ (), (1,2) ])
-gap> STOP_TEST("2018-12-06-GroupWithGenerators.tst", 1);
+gap> STOP_TEST("2018-12-06-GroupWithGenerators.tst");

tst/testbugfix/2022-09-09-MinimalGeneratingSet.tst

@@ -3,4 +3,4 @@ gap> G:=Group((1,2),(2,3),(3,4));;
 gap> H:=Image(IsomorphismFpGroup(G));;
 gap> MinimalGeneratingSet(H);
 [ F1^-1*F2^-1*F3^-1, F1^-1*F2^-1*F3^-1*F2^-1*F1^-1 ]
-gap> STOP_TEST("2022-09-09-MinimalGeneratingSet.tst", 1);
+gap> STOP_TEST("2022-09-09-MinimalGeneratingSet.tst");

tst/testextra/ctblpope.tst

@@ -53,4 +53,4 @@ gap> if IsPackageMarkedForLoading( "ctbllib", "" ) then
 > fi;
 
 ##
-gap> STOP_TEST( "ctblpope.tst", 1 );
+gap> STOP_TEST("ctblpope.tst");

tst/testextra/grpauto.tst

@@ -323,4 +323,4 @@ gap> gp2:=Group((3,19,53,9,34)(6,29,69,15,48)(8,72,52,33,18)
 > (174,178,233,203,238)(177,217,244,190,194));;
 gap> IsomorphismGroups(gp1,gp2)=fail;
 false
-gap>STOP_TEST("grpauto.tst",1);
+gap>STOP_TEST("grpauto.tst");

tst/testextra/grpperm.tst

@@ -266,4 +266,4 @@ gap> Length(p);
 gap> p:=List(p,x->Image(IsomorphismPermGroup(x)));;
 gap> List(p,Size);
 [ 61440, 61440, 61440, 61440 ]
-gap> STOP_TEST( "grpperm.tst", 1);
+gap> STOP_TEST("grpperm.tst");

tst/testextra/helpsys.tst

@@ -17,4 +17,4 @@ gap> for i in [1..Length(HELP_LAST.TOPICS)] do HELP(String(i)); od;
 gap> PAGER_EXTERNAL:=savepager;;
 gap> MakeReadOnlyGlobal("PAGER_EXTERNAL");
 gap> SetUserPreference("Pager",savepagerprefs);
-gap> STOP_TEST( "helpsys.tst", 1);
+gap> STOP_TEST("helpsys.tst");

tst/testextra/objmap.tst

@@ -44,4 +44,4 @@ gap> SortedList(OBJ_MAP_KEYS(y)) = keyresult;
 true
 gap> SortedList(OBJ_MAP_VALUES(y)) = valresult;
 true
-gap> STOP_TEST( "objmap.tst", 1);
+gap> STOP_TEST("objmap.tst");

tst/testextra/objset.tst

@@ -35,4 +35,4 @@ gap> GASMAN("collect");
 gap> result := List([1..setvals], x -> [x,[x]]);;
 gap> SortedList(OBJ_SET_VALUES(y)) = result;
 true
-gap> STOP_TEST( "objset.tst", 1);
+gap> STOP_TEST("objset.tst");

tst/testextra/perfect.tst

@@ -22,4 +22,4 @@ gap> gp:=FpGroupCocycle(coh,coh.cohomology[1],true);;
 gap> gp:=Image(IsomorphismPermGroup(gp));;
 gap> Size(Group(GeneratorsOfGroup(gp)));
 61440
-gap> STOP_TEST( "perfect.tst", 1);
+gap> STOP_TEST("perfect.tst");

tst/testextra/small_groups2.tst

@@ -19,4 +19,4 @@ gap> for n in [1..Length(NAMES_OF_SMALL_GROUPS)] do
 > od;
 gap> bad;
 [  ]
-gap> STOP_TEST( "small_groups2.tst", 1);
+gap> STOP_TEST("small_groups2.tst");

tst/testextra/switch_obj.tst

@@ -66,4 +66,4 @@ gap> checkswap := function(switches)
 >  end;;
 gap> ForAll(Combinations([1,2,3,4,5,6,7,8,9]), checkswap);
 true
-gap> STOP_TEST( "mptr.tst", 1);
+gap> STOP_TEST("mptr.tst");

tst/testinstall/ElmsBlist.tst

@@ -14,4 +14,4 @@ gap> doTests := function(startrange, lengthrange)
 >    od;
 > end;;
 gap> doTests([1..64],[0..128]);
-gap> STOP_TEST("ElmsBlist.tst", 1);
+gap> STOP_TEST("ElmsBlist.tst");

tst/testinstall/MatrixObj/ConcatenationOfVectors.tst

@@ -20,4 +20,4 @@ gap> vv := ConcatenationOfVectors( [ v3, v4, v3 ] );
 gap> Unpack( vv );
 [ Z(5)^0, Z(5), Z(5)^3, Z(5)^2, 0*Z(5), Z(5)^0, Z(5)^0, Z(5), Z(5), Z(5)^2, 
   0*Z(5), Z(5)^0, Z(5)^0, Z(5), Z(5)^3, Z(5)^2, 0*Z(5), Z(5)^0 ]
-gap> STOP_TEST("ConcatenationOfVectors.tst",1);
+gap> STOP_TEST("ConcatenationOfVectors.tst");

tst/testinstall/MatrixObj/DistanceOfVectors.tst

@@ -29,4 +29,4 @@ gap> DistanceOfVectors( v5, v6 );
 3
 gap> DistanceOfVectors( v4, v6 );
 5
-gap> STOP_TEST( "DistanceOfVectors.tst", 1);
+gap> STOP_TEST("DistanceOfVectors.tst");

tst/testinstall/MatrixObj/ElementaryMatrices.tst

@@ -119,4 +119,4 @@ gap> mat := Matrix( [[2,4,5],[7,11,-4],[-3,20,0]]);;
 gap> AddMatrixColumnsLeft(mat,1,3,-3);
 gap> mat= Matrix( [ [-13,4,5], [19,11,-4], [-3,20,0]]);
 true
-gap> STOP_TEST("ElementaryMatrices.tst",1);
+gap> STOP_TEST("ElementaryMatrices.tst");

tst/testinstall/MatrixObj/ExtractSubvector.tst

@@ -11,4 +11,4 @@ gap> ExtractSubVector( v1, [1,2,4] );
 <plist vector over Rationals of length 3>
 gap> Unpack( last );
 [ 1, 2, 4 ]
-gap> STOP_TEST("ExtractSubVector.tst",1);
+gap> STOP_TEST("ExtractSubVector.tst");

tst/testinstall/MatrixObj/ListOp.tst

@@ -23,4 +23,4 @@ gap> List( v );
 [  ]
 gap> List( v, DegreeFFE );
 [  ]
-gap> STOP_TEST( "ListOp.tst", 1);
+gap> STOP_TEST("ListOp.tst");

tst/testinstall/MatrixObj/PositionNonZero.tst

@@ -29,4 +29,4 @@ gap> v6 := Vector(GF(5), l3*One(GF(5)));
 [ 0*Z(5), 0*Z(5), 0*Z(5), 0*Z(5), 0*Z(5), 0*Z(5) ]
 gap> PositionNonZero( v6 );
 7
-gap> STOP_TEST( "PositionNonZero.tst", 1);
+gap> STOP_TEST("PositionNonZero.tst");

tst/testinstall/MatrixObj/TraceMat.tst

@@ -10,4 +10,4 @@ gap> TraceMat( m2 );
 5
 gap> TraceMat( m3 );
 Z(7)^5
-gap> STOP_TEST( "TraceMat.tst", 1);
+gap> STOP_TEST("TraceMat.tst");

tst/testinstall/MatrixObj/Unpack.tst

@@ -9,4 +9,4 @@ gap> v5 := Vector(GF(5), ll*One(GF(5)));
 [ Z(5)^0, Z(5), Z(5)^3, Z(5)^2, 0*Z(5), Z(5)^0 ]
 gap> Unpack( v5 );
 [ Z(5)^0, Z(5), Z(5)^3, Z(5)^2, 0*Z(5), Z(5)^0 ]
-gap> STOP_TEST( "Unpack.tst", 1);
+gap> STOP_TEST("Unpack.tst");

tst/testinstall/MatrixObj/WeightOfVector.tst

@@ -29,4 +29,4 @@ gap> v6 := Vector(GF(5), l3*One(GF(5)));
 [ 0*Z(5), 0*Z(5), 0*Z(5), 0*Z(5), 0*Z(5), 0*Z(5) ]
 gap> WeightOfVector( v6 );
 0
-gap> STOP_TEST( "WeightOfVector.tst", 1);
+gap> STOP_TEST("WeightOfVector.tst");

tst/testinstall/alghom.tst

@@ -101,4 +101,4 @@ gap> Q:=R/id;
 <ring with 1 generator>
 gap> Elements(Q);
 [ 0*q1, q1, 2*q1, 3*q1, 4*q1, 5*q1, 6*q1, -q1 ]
-gap> STOP_TEST( "alghom.tst", 1);
+gap> STOP_TEST("alghom.tst");

tst/testinstall/algmat.tst

@@ -285,4 +285,4 @@ true
 # missing: natural modules, abstract expressions, field multiplicity
 
 #############################################################################
-gap> STOP_TEST( "algmat.tst", 1);
+gap> STOP_TEST("algmat.tst");

tst/testinstall/algrep.tst

@@ -137,4 +137,4 @@ gap> V:= BiAlgebraModuleByGenerators( A, A, \*, \*, [ [1,0,0] ], "basis" );
 [ 3, 3 ] ) (right)>
 
 #
-gap> STOP_TEST( "algrep.tst", 1);
+gap> STOP_TEST("algrep.tst");

tst/testinstall/algsc.tst

@@ -929,4 +929,4 @@ gap> List( GeneratorsOfAlgebra( A ), x -> x^2 );
 [ s1, t1, 0*s1, 0*s1, 0*s1, 0*s1, 0*s1, 0*s1 ]
 
 #############################################################################
-gap> STOP_TEST( "algsc.tst", 1);
+gap> STOP_TEST("algsc.tst");

tst/testinstall/associate.tst

@@ -57,4 +57,4 @@ gap> for A in [ GF(5), Integers, Rationals ] do
 >    od;
 
 #
-gap> STOP_TEST("associate.tst", 1);
+gap> STOP_TEST("associate.tst");

tst/testinstall/attribute.tst

@@ -103,4 +103,4 @@ gap> SetStabChainMutable(grp, [3,4]);
 gap> StabChainMutable(grp);
 [ 3, 4 ]
 gap> SetInfoLevel(InfoAttributes, attributeinfo);
-gap> STOP_TEST("attribute.tst", 1);
+gap> STOP_TEST("attribute.tst");

tst/testinstall/bitfields.tst

@@ -77,4 +77,4 @@ gap> NameFunction(bf.booleanSetters[1]);
 "<boolean field setter>"
 
 #
-gap> STOP_TEST("bitfields.tst", 1);
+gap> STOP_TEST("bitfields.tst");

tst/testinstall/boolean.tst

@@ -123,4 +123,4 @@ gap> function() return IsAssociative and IsAssociative; end();
 <Property "IsAssociative">
 
 #
-gap> STOP_TEST( "boolean.tst", 1);
+gap> STOP_TEST("boolean.tst");

tst/testinstall/bound.tst

@@ -49,4 +49,4 @@ gap> Display(function(l,n) return IsBound(l.(n));end);
 function ( l, n )
     return IsBound( l.(n) );
 end
-gap> STOP_TEST("bound.tst", 1);
+gap> STOP_TEST("bound.tst");

tst/testinstall/break.tst

@@ -144,4 +144,4 @@ gap> f := function() local i; i := 1; repeat i := i + 1; break; until i in [1..5
 gap> f();
 
 #
-gap> STOP_TEST("break.tst", 1);
+gap> STOP_TEST("break.tst");

tst/testinstall/callfunc.tst

@@ -149,4 +149,4 @@ gap> f := function() return o2(1,2,3,4,6,7); end;; f();
 Error, Function Calls: <func> must return a value
 gap> f := function() return o2(1,2,3,4,5,6,7); end;; f();
 Error, Function Calls: <func> must return a value
-gap> STOP_TEST( "callfunc.tst", 1);
+gap> STOP_TEST("callfunc.tst");

tst/testinstall/coder.tst

@@ -337,4 +337,4 @@ function() for PrintObj{[1]} in [1,2,3] do od; end();
                        ^
 
 #
-gap> STOP_TEST("coder.tst", 1);
+gap> STOP_TEST("coder.tst");

tst/testinstall/coding.tst

@@ -130,4 +130,4 @@ function ( x )
 end
 
 #
-gap> STOP_TEST("coding.tst", 1);
+gap> STOP_TEST("coding.tst");

tst/testinstall/coll.tst

@@ -688,4 +688,4 @@ gap> Difference(M2, [1]);
 [ 0 ]
 
 #
-gap> STOP_TEST( "coll.tst", 1);
+gap> STOP_TEST("coll.tst");

tst/testinstall/combinat.tst

@@ -558,4 +558,4 @@ gap> AssociatedPartition(Concatenation([7],ListWithIdenticalEntries(99,1)));
 [ 100, 1, 1, 1, 1, 1, 1 ]
 
 # that's it for the combinatorial package  ##################################
-gap> STOP_TEST( "combinat.tst", 1);
+gap> STOP_TEST("combinat.tst");

tst/testinstall/cset.tst

@@ -145,4 +145,4 @@ gap> RightCoset(Group( [ [ Z(3)^0, 0*Z(3) ], [ 0*Z(3), Z(3)^0 ] ] ),
 true
 
 #
-gap> STOP_TEST("cset.tst", 1);
+gap> STOP_TEST("cset.tst");

tst/testinstall/ctblfuns.tst

@@ -91,4 +91,4 @@ gap> chi = chi^0;
 true
 
 #
-gap> STOP_TEST( "ctblfuns.tst", 1);
+gap> STOP_TEST("ctblfuns.tst");

tst/testinstall/ctblmoli.tst

@@ -54,4 +54,4 @@ gap> ser = ser2;
 true
 
 #
-gap> STOP_TEST( "ctblmoli.tst", 1);
+gap> STOP_TEST("ctblmoli.tst");

tst/testinstall/ctblmono.tst

@@ -328,4 +328,4 @@ gap> IsMinimalNonmonomial( S4 );
 false
 
 ##
-gap> STOP_TEST( "ctblmono.tst", 1);
+gap> STOP_TEST("ctblmono.tst");

tst/testinstall/ctblsolv.tst

@@ -9,4 +9,4 @@ gap> for pair in [ [ 18, 3 ], [ 27, 3 ], [ 36, 7 ], [ 50, 3 ], [ 54, 4 ] ] do
 >        Error( IdGroup( G ) );
 >      fi;
 >    od;
-gap> STOP_TEST( "ctblsolv.tst", 1);
+gap> STOP_TEST("ctblsolv.tst");

tst/testinstall/cyclotom.tst

@@ -353,4 +353,4 @@ gap> SetX(r, r, {i,j} -> (sets[i]=sets[j]) = (i=j));
 [ true ]
 
 #
-gap> STOP_TEST( "cyclotom.tst", 1);
+gap> STOP_TEST("cyclotom.tst");

tst/testinstall/depth.tst

@@ -30,4 +30,4 @@ Error, no method found! For debugging hints type ?Recovery from NoMethodFound
 Error, no 1st choice method found for `IsCommutative' on 1 arguments
 gap> dive(80);
 Depth 80
-gap> STOP_TEST( "depth.tst", 1);
+gap> STOP_TEST("depth.tst");

tst/testinstall/dict.tst

@@ -20,4 +20,4 @@ gap> for i in [1..1000] do
 > od;
 gap> dict;
 <sparse hash table of size 1002>
-gap> STOP_TEST( "dict.tst", 1);
+gap> STOP_TEST("dict.tst");

tst/testinstall/dir.tst

@@ -32,4 +32,4 @@ gap> if ARCH_IS_WINDOWS() then
 >       ExternalFilename(Directory("/cygdrive/Q/"), "filename") = "/cygdrive/Q/filename","\n");
 > fi;
 truetruetruetrue
-gap> STOP_TEST("dir.tst", 1);
+gap> STOP_TEST("dir.tst");

tst/testinstall/dt.tst

@@ -121,4 +121,4 @@ gap> Rules(collH);
   f8^-1*f10*f8*f10^-1, f9^-1*f10*f9*f10^-1 ]
 
 #
-gap> STOP_TEST("dt.tst", 1);
+gap> STOP_TEST("dt.tst");

tst/testinstall/eigen.tst

@@ -10,4 +10,4 @@ gap> GeneralisedEigenvalues(GF(3), A );
 gap> GeneralisedEigenspaces(GF(3),A);
 [ <vector space over GF(3), with 1 generator>, 
   <vector space over GF(3), with 3 generators> ]
-gap> STOP_TEST( "eigen.tst", 1);
+gap> STOP_TEST("eigen.tst");

tst/testinstall/euclidean.tst

@@ -57,4 +57,4 @@ gap> checkEuclideanRing(Integers mod ((2*3*5*7)^3));
 true
 
 #
-gap> STOP_TEST( "euclidean.tst", 1);
+gap> STOP_TEST("euclidean.tst");

tst/testinstall/ffe.tst

@@ -513,4 +513,4 @@ gap> ForAll(qs,x->Rochambeau(GF(x))=0);
 true
 
 #
-gap> STOP_TEST( "ffe.tst", 1);
+gap> STOP_TEST("ffe.tst");

tst/testinstall/ffeconway.tst

@@ -795,4 +795,4 @@ gap> SetInfoLevel(InfoPrimeInt,iPI);
 gap> SetInfoLevel(InfoFactor,iF);
 gap> if IsBound(InfoFactInt) then SetInfoLevel(InfoFactInt,iFI); fi;
 gap> SetInfoLevel(InfoWarning,iW);
-gap> STOP_TEST( "ffeconway.tst", 1);
+gap> STOP_TEST("ffeconway.tst");

tst/testinstall/files/files.tst

@@ -108,4 +108,4 @@ gap> testRead("empty.txt", {} -> InputTextFile(Filename(dir, "empty.txt")),
 gap> testRead("lines string", {} -> InputTextString(Concatenation(lines)), lines, true);
 gap> testRead("empty string", {} -> InputTextString(""), [], true);
 gap> testRead("dummy input", {} -> InputTextNone(), [], true);
-gap> STOP_TEST("files.tst", 1);
+gap> STOP_TEST("files.tst");

tst/testinstall/float.tst

@@ -821,4 +821,4 @@ gap> DisplayString(1.3);
 "1.3\n"
 
 #
-gap> STOP_TEST( "float.tst", 1);
+gap> STOP_TEST("float.tst");

tst/testinstall/flush.tst

@@ -25,4 +25,4 @@ gap> cheeseval;
 [ 2 ]
 gap> MakeReadWriteGlobal("cheesefun"); UnbindGlobal("cheesefun");
 gap> MakeReadWriteGlobal("cheeseval"); UnbindGlobal("cheeseval");
-gap> STOP_TEST("flush.tst", 1);
+gap> STOP_TEST("flush.tst");

tst/testinstall/format.tst

@@ -104,4 +104,4 @@ gap> PrintFormatted("abc{3}\n", 2);
 Error, out of bounds -- asked for {3} when there are only 1 arguments
 gap> PrintFormatted("abc{x}\n", rec(y := 2));
 Error, no record member 'x'
-gap> STOP_TEST("format.tst",1);
+gap> STOP_TEST("format.tst");

tst/testinstall/fpmon.tst

@@ -44,4 +44,4 @@ gap> y in S;
 true
 
 #
-gap> STOP_TEST( "fpmon.tst", 1);
+gap> STOP_TEST("fpmon.tst");

tst/testinstall/function.tst

@@ -340,4 +340,4 @@ gap> funcloop(x -> ([ [ x ] ]{[ 1 ]}{[ 1 ]}){[ 1 ]}); # EXPR_ELMS_LIST
 function ( x ) return ([ [ x ] ]{[ 1 ]}{[ 1 ]}){[ 1 ]}; end
 
 #
-gap> STOP_TEST("function.tst", 1);
+gap> STOP_TEST("function.tst");

tst/testinstall/gaussian.tst

@@ -86,4 +86,4 @@ gap> Factors( GaussianIntegers, 1+2*E(4) );
 [ 1+2*E(4) ]
 gap> Factors( GaussianIntegers, 5-E(4) );
 [ 1-E(4), 3+2*E(4) ]
-gap> STOP_TEST( "gaussian.tst", 1);
+gap> STOP_TEST("gaussian.tst");

tst/testinstall/gprdmat.tst

@@ -88,4 +88,4 @@ gap> Image(emb);
 <matrix group with 3 generators>
 
 #
-gap> STOP_TEST("gprdmat.tst", 1);
+gap> STOP_TEST("gprdmat.tst");

tst/testinstall/grp/basic.tst

@@ -571,4 +571,4 @@ Error, no method found! For debugging hints type ?Recovery from NoMethodFound
 Error, no 1st choice method found for `SymmetricGroupCons' on 2 arguments
 
 #
-gap> STOP_TEST("basic.tst", 1);
+gap> STOP_TEST("basic.tst");

tst/testinstall/grp/classic-G.tst

@@ -280,4 +280,4 @@ gap> for d in [ 1 .. 10 ] do
 > od;
 
 #
-gap> STOP_TEST("classic-G.tst", 1);
+gap> STOP_TEST("classic-G.tst");

tst/testinstall/grp/classic-PG.tst

@@ -139,4 +139,4 @@ gap> PGammaL( 3, 6 );
 Error, usage: GeneralLinearGroup( [<filter>, ]<d>, <R> )
 
 #
-gap> STOP_TEST("classic-PG.tst", 1);
+gap> STOP_TEST("classic-PG.tst");

tst/testinstall/grp/classic-PS.tst

@@ -85,4 +85,4 @@ gap> PSigmaL( 3, 6 );
 Error, usage: SpecialLinearGroup( [<filter>, ]<d>, <R> )
 
 #
-gap> STOP_TEST("classic-PS.tst", 1);
+gap> STOP_TEST("classic-PS.tst");