Skip to content

Commit

Permalink
buildsys: tweak GAC_LDFLAGS on macOS (#5789)
Browse files Browse the repository at this point in the history
- don't use a bundle loader (esp. for installed GAP)
- don't use flat namespace, instead use dynamic lookup
- use `-Wl,-no_fixup_chains` to avoid warnings (and resolve
  potential issues) with certain Xcode versions, see
  <python/cpython#97524>
  • Loading branch information
fingolfin authored Sep 5, 2024
1 parent b68674e commit d94809d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile.rules
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ ifneq (,$(findstring cygwin,$(host_os)))
else
ifneq (,$(findstring darwin,$(host_os)))
GAC_CFLAGS = -fno-common
GAC_LDFLAGS = -bundle -flat_namespace -bundle_loader $(SYSINFO_GAP)
GAC_LDFLAGS = -bundle -undefined dynamic_lookup -Wl,-no_fixup_chains
else
GAC_CFLAGS = -fPIC
GAC_LDFLAGS = -shared -fPIC
Expand Down

0 comments on commit d94809d

Please sign in to comment.