Update for recent gaplint (#5785)

.gaplint.yml

@@ -1,38 +1,4 @@
-disable:
-- W001
-- W002
-- W003
-- W004
-- W005
-- W006
-- W008
-- W009
-- W010
-- W011
-- W012
-- W013
-- W014
-- W015
-- W016
-- W018
-- W019
-- W020
-- W021
-- W022
-- W023
-- W024
-- W025
-- W026
-- W027
-- W028
-- W029
-- W030
-- W031
-- W032
-- W033
-- W034
-- W035
-- W036
-- W037
-- W038
-- W039
+enable:
+- analyse-lvars
+- tabs
+- trailing-whitespace

.github/workflows/lint.yml

@@ -21,6 +21,6 @@ jobs:
         with:
           python-version: '3.10'
       - name: "Install gaplint with pip"
-        run: pip install gaplint==1.1.5
+        run: pip install gaplint==1.3.2
       - name: "Run gaplint lib/*.g* hpcgap/lib/*.g* grp/*.g lib/hpc/*.g hpcgap/lib/hpc/*.g . . ."
         run: gaplint lib/*.g* hpcgap/lib/*.g* grp/*.g lib/hpc/*.g hpcgap/lib/hpc/*.g

lib/grpfp.gi

@@ -1,4 +1,3 @@
-# gaplint: disable = analyse-lvars
 #############################################################################
 ##
 ##  This file is part of GAP, a system for computational discrete algebra.
@@ -3980,7 +3979,7 @@ end);
 ##
 InstallGlobalFunction(IsomorphismPermGroupOrFailFpGroup,
 function(arg)
-local mappow, G, max, p, gens, rels, comb, i, l, m, H, HH, t, gen, sz,
+local mappow, G, max, p, gens, rels, comb, i, l, m, H, HH, t, sz,
   t1, bad, trial, b, bs, r, nl, o, u, rp, eo, rpo, e, e2, sc, j, z,
   timerFunc,amax,iso,useind;
 

lib/kbsemi.gi

@@ -11,7 +11,6 @@
 ##  This file contains code for the Knuth-Bendix rewriting system for semigroups
 ##  and monoids.
 ##
-# gaplint: disable = analyse-lvars
 
 InstallGlobalFunction(EmptyKBDAG,function(genids)
 local offset,deadend;
@@ -876,7 +875,7 @@ end);
 
 BindGlobal("GKB_MakeKnuthBendixRewritingSystemConfluent",
 function(kbrws)
-local   pn,lp,rl,p,i,a;
+local   pn,lp,rl,p,i;
 
   if IsBound(kbrws!.invmap) then
     kbrws!.fellowTravel:=[];