Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always enable pthread flags #5196

Closed
wants to merge 2 commits into from
Closed

Always enable pthread flags #5196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
423a23b
Always enable pthread flags
fingolfin Nov 7, 2022
6c7c97f
Extend timeout, as CI can be very slow to start GAP
ChrisJefferson Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,9 +1069,15 @@ dnl check for non-standard math functions
AC_CHECK_FUNCS([exp10])

dnl pthreads
AS_IF([test "x$enable_hpcgap" = xyes -o "x$with_julia" != xno ],[
dnl we unconditionally check for these flags (and use them), even though we
dnl only use pthreads if HPC-GAP is enabled. Als0, if a kernel extension uses
dnl pthreads, then it may be necessary under certain Linux variants that the
dimpase marked this conversation as resolved.
Show resolved Hide resolved
dnl gap executable is linked with flags like `-pthread`. If it is not, then
dnl using the kernel extension will lead to a runtime exception.
dnl See also <https://github.com/gap-system/gap/issues/5192>
#AS_IF([test "x$enable_hpcgap" = xyes -o "x$with_julia" != xno ],[
AX_PTHREAD
])
# ])

dnl backtraces via execinfo
AX_EXECINFO
Expand Down
2 changes: 1 addition & 1 deletion dev/gaptest.expect
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
set timeout 10
set timeout 60

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that's slow. Do you have any idea what it is doing in this time? I.e. what makes it so slow?

I tried time ./gap -A -c 'QUIT;' on a bunch of machine just now, with HPC-GAP and debug mode enabled, and it still starts within ~2 seconds on the slowest I could find (WSL inside a Windows VM).

We've also in the past disabled some HPC-GAP tests because they were so super slow in the VM and could never figure out why... This seems to be related?

# from https://serverfault.com/a/981762
expect_before {
Expand Down
Loading