Fix an error in the Modified Todd-Coxeter (subgroup presentations on specified generators) that could lead to wrong results when using IsomorphismFpGroupByGenerators
#5469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A replacement routine had been improved to also allow for cyclic replacement, but that may only be used on relators, not on representatives.
fingolfin
added
kind: bug
fingolfin
changed the title
fingolfin
changed the title
IsomorphismFpGroupByGenerators
|
Is there a reason to take this out of the existing PR without approving that PR itself? |
|
Yes. Your existing PR mushes together a bunch of unrelated changes. So to review, approve and merge it will take much longer. Moving this independent part into a separate PR simplifies the review process and will get it merged much quicker. (The same would hold for other parts of your PR, which also seem independent). I would normally require contributors to submit separate changes in separate PRs, but make an exception for you, and do the splitting for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A replacement routine had been improved to also allow for cyclic
replacement, but that may only be used on relators, not on representatives.
Fixes #5467
Extracted from PR #5468 by @hulpke