fixed ConsiderStructureConstants
#5487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may happen that `ConsiderStructureConstants` excludes all candidates. Up to now, it was possible that one runs into an error in such a case because the function wants to proceed and tries to access entries in an empty list. Benjamin Sambale found an example in which the `quick` parameter is set to `true` and hence some candidates do not get excluded in an earlier step, but the error could in principle happen also with the default setting `quick:= false`.
ThomasBreuer
added
kind: bug
frankluebeck
previously requested changes
Aug 17, 2023
There was a problem hiding this comment.
Both, the improvement of the documentation of PossibleClassFusions, and the fix of the code for ConsiderStructureConstants look fine to me.
Maybe this PR could contain another fix: the documentation of ConsiderStructureConstants contains "for which" twice in a row.
fingolfin
reviewed
Aug 18, 2023
| ## with character table <A>subtbl</A>, it may happen that setting | ||
| ## <C>quick</C> to <K>true</K> causes <Ref Oper="PossibleClassFusions"/> | ||
| ## to return solutions, | ||
| ## whereas the value <K>false</K> yields an empty list), |
There was a problem hiding this comment.
Not a change request for this PR, but perhaps a remark for a future revision: this is part of a single sentence starting in line 920 and continuing for over 60 lines. That strikes me as very "German" and not particularly reader friendly ;-). Surely some of those ; could be turned into . ?
fingolfin
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may happen that
ConsiderStructureConstantsexcludes all candidates.Up to now, it was possible that one runs into an error in such a case because the function wants to proceed and tries to access entries in an empty list.
Benjamin Sambale found an example in which the
quickparameter is set totrueand hence some candidates do not get excluded in an earlier step, but the error could in principle happen also with the default settingquick:= false.