-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to hash functions for lists #5796
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use list hashing for lists of integers, not lists of vectors. This fixes gap-system#5786
This change is commented out, as a change in main branch already resolved it, but code is preserved in case needed at later time: This fixes an issue reported in support by Leonard Soicher on Sep 13, 2024.
hulpke
added
kind: bug: unexpected error
Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them
release notes: not needed
PRs introducing changes that are wholly irrelevant to the release notes
labels
Sep 14, 2024
OK, this fixes #5786
which passes with this PR, and fails without. PS. Oh, it's there already. Sorry for noise. All good. |
if there is a "rule" that there should be no spaces around |
dimpase
approved these changes
Sep 15, 2024
2 tasks
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Oct 9, 2024
Backport gap-system/gap#5796 because it's causing failures in the SageMath test suite when dev-gap/grape also happens to be installed. Thanks to Dima Pasechnik for the pointer. Signed-off-by: Michael Orlitzky <mjo@gentoo.org>
5 tasks
orlitzky
added a commit
to orlitzky/sage
that referenced
this pull request
Oct 12, 2024
Fixes gap-system/gap#5796 This is the patch I'm using on Gentoo, it combines the upstream fix and one of its dependencies (without which the desired fix does not apply). Without it, you'll get some test failures with gap-4.13.x when GRAPE happens to be installed.
orlitzky
added a commit
to orlitzky/sage
that referenced
this pull request
Oct 12, 2024
Fixes gap-system/gap#5796 This is the patch I'm using on Gentoo, it combines the upstream fix and one of its dependencies (without which the desired fix does not apply). Without it, you'll get some test failures with gap-4.13.x when GRAPE happens to be installed.
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 20, 2024
Follow-up to: * sagemath#37884 * sagemath#38169 With the four additional work items I mentioned in a comment on the latter: 1. Everything has been rebased 2. There's a new feature to detect the polenta GAP package 3. The three failing simplicial sets tests have been marked `# needs gap_package_polenta` 4. I backported gap-system/gap#5796 to the GAP spkg so that the optional GRAPE tests will pass (untested). Let's see what the CI has to say... URL: sagemath#38804 Reported by: Michael Orlitzky Reviewer(s): Dima Pasechnik, Enrique Manuel Artal Bartolo
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 23, 2024
Follow-up to: * sagemath#37884 * sagemath#38169 With the four additional work items I mentioned in a comment on the latter: 1. Everything has been rebased 2. There's a new feature to detect the polenta GAP package 3. The three failing simplicial sets tests have been marked `# needs gap_package_polenta` 4. I backported gap-system/gap#5796 to the GAP spkg so that the optional GRAPE tests will pass (untested). Let's see what the CI has to say... URL: sagemath#38804 Reported by: Michael Orlitzky Reviewer(s): Dima Pasechnik, Enrique Manuel Artal Bartolo
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 26, 2024
Follow-up to: * sagemath#37884 * sagemath#38169 With the four additional work items I mentioned in a comment on the latter: 1. Everything has been rebased 2. There's a new feature to detect the polenta GAP package 3. The three failing simplicial sets tests have been marked `# needs gap_package_polenta` 4. I backported gap-system/gap#5796 to the GAP spkg so that the optional GRAPE tests will pass (untested). Let's see what the CI has to say... URL: sagemath#38804 Reported by: Michael Orlitzky Reviewer(s): Dima Pasechnik, Enrique Manuel Artal Bartolo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind: bug: unexpected error
Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them
release notes: not needed
PRs introducing changes that are wholly irrelevant to the release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit scope of list hashing to permutations acting by permuting, thus avoiding problems when acting with matrices on lists of vectors. This fixes #5786
Also acknowledge, in test, related error reported in support, that already had been fixed in master