Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a mutability inconsistency of ExtRepOfObj values of objects in IsLetterAssocWordRep #5802

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

ThomasBreuer
Copy link
Contributor

Up to now, we get

gap> f:= FreeGroup(IsLetterWordsFamily,4);;
gap> IsMutable(ExtRepOfObj(f.1));
true
gap> IsMutable(ExtRepOfObj(f.1));
false

The point is that an immutable version of the result gets cached after the first call, and this cached version is used in the second call.
With the proposed change, also the first result is already immutable.

of objects in `IsLetterAssocWordRep`
@ThomasBreuer ThomasBreuer added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: library release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Sep 20, 2024
@fingolfin fingolfin merged commit 5c79e69 into gap-system:master Sep 20, 2024
33 checks passed
@fingolfin
Copy link
Member

This promptly broke the test suites in semigroups (ping @james-d-mitchell) and groupoids (ping @cdwensley). At least that is how I interpret the test failures for groupoids and semigroups.

@james-d-mitchell
Copy link
Contributor

@fingolfin interesting, this should be easy enough to fix, will try to do it today.

@cdwensley
Copy link
Contributor

@fingolfin: groupoids fixed - version 1.76 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants