Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: from bridge.framework.django import configure #27

Merged
merged 3 commits into from
May 14, 2024

Conversation

Abdenasser
Copy link
Contributor

@Abdenasser Abdenasser commented May 5, 2024

this updates documentation to import configure from bridge.framework.django instead of bridge.django

I'm aware that you are exposing django in the __init__.py like this:

from bridge.framework import django
all = ["django"]

but that is not going to expose the configure function on bridge.django directly unless we are importing django like so:

from bridge import django
django.configure(locals())

@Abdenasser Abdenasser changed the title fix: django is now under bridge.framework fix: from bridge.framework.django import configure May 5, 2024
Copy link
Member

@emdoyle emdoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

I adjusted the import path to from bridge import django instead, since this looks a bit nicer.

@emdoyle emdoyle merged commit 9b6c5b1 into gauge-sh:main May 14, 2024
4 checks passed
@Abdenasser
Copy link
Contributor Author

@emdoyle thanks 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants