-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Windows Installation instructions #381
Conversation
Signed-off-by: Martin Pecka <peci1@seznam.cz> Signed-off-by: Martin Pecka <peci1@seznam.cz>
Signed-off-by: Martin Pecka <peci1@seznam.cz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, thanks for working on this!
Signed-off-by: Martin Pecka <peci1@seznam.cz>
Signed-off-by: Martin Pecka <peci1@seznam.cz>
All comments should be resolved now. |
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some formatting things.
While we're here, I noticed some indentation mistakes in the original page that existed before this PR, so I pushed ab0cf96 to fix them.
Co-authored-by: Mabel Zhang <mabel.m.zhang@gmail.com> Signed-off-by: Martin Pecka <peci1@seznam.cz>
Signed-off-by: Martin Pecka <peci1@seznam.cz>
Thanks for the formatting improvements. I turned all WARNINGs into NOTEs. |
🎉 New feature
Summary
Going through the Windows install instructions for Harmonic, these are a few changes that will hopefully enable more users to finish the installation.
Test it
Try installing it :-D
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.