Port ROS 2 Integration Tutorials to Fortress and Harmonic #387
Conversation
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Co-authored-by: Mabel Zhang <mabel@openrobotics.org> Signed-off-by: Dharini Dutia <dharinidutia@gmail.com>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
quarkytale
added
documentation
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
There was a problem hiding this comment.
Thank you for these tutorials! I'm still not able to load the Docs page in my local copy of the website, so I just read things on GitHub.
In the larger scope of categorizing documentation into the 4 types, I would say this should be grouped under How-To Guides than Tutorials. It assumes some knowledge; it isn't at the very beginner level with step-by-step hand-holding instructions. Keep that in mind when we get to grouping tutorials on the main website with ones from gz-sim per-library tutorials...
| @@ -1,16 +1,17 @@ | |||
| # ROS 2 Integration | |||
|
|
|||
| In this tutorial we will learn how to Integrate ROS 2 with Gazebo. We will establish | |||
| communication between them. This can help in many aspects; we can receive data or commands | |||
| from ROS and apply it to Gazebo and vice versa. | |||
| communication between them. This can help in many aspects; we can receive data (like joint states, TFs) or commands | |||
There was a problem hiding this comment.
Just to double-check, this file doesn't need to be updated in Fortress? There's no diff for this file in Fortress.
There was a problem hiding this comment.
So only ros2 branch of ros_gz has this functionality, initially I thought Fortress isn't compatible but Fortress + Rolling would work. Will add that tidbit in all and the tutorial to Fortress.
There was a problem hiding this comment.
Fortress is the official version shipped with ROS 2 Humble (I believe it ships with desktop-full), and it's the recommended Gazebo version for Humble. Both Fortress and Humble are LTS, so I would hope that this works...
There was a problem hiding this comment.
Okay I confirmed this exists with humble branch as well, https://github.com/gazebosim/ros_gz/blob/humble/ros_gz_sim_demos/launch/sdf_parser.launch.py will work!
There was a problem hiding this comment.
Oh but it's not in ros_ign_gazebo_demos, so as per the ros_gz compatibility table it'll work with Rolling only. Is it okay if we don't block this for now, I won't make further additions? I'll do some tests or backward ports if required to ensure the recommended combinations work. I'll update the issue to include this.
There was a problem hiding this comment.
Yeah that's fine. Thank you for looking into it!
Co-authored-by: Mabel Zhang <mabel@openrobotics.org> Signed-off-by: Dharini Dutia <dharinidutia@gmail.com>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
quarkytale
force-pushed
the
port_tutorials
branch
from
db5b670 to
e16f3e7
Compare
#371 to Fortress & Harmonic
#364 to Harmonic