Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of enable_gcc8 script to fix focal builds #389

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Sep 14, 2023

🦟 Bug fix

Summary

Focal based docker containers were failing to build documentation because running enable_gcc8.sh script fails.

Try using:

docker build -t gz-fortress-docs -f Dockerfile.fortress --build-arg GZ_VERSION_PASSWORD=foo --build-arg GZ_VERSION_DATE=5 --build-arg AWS_ACCESS_KEY_ID=foo --build-arg AWS_SECRET_ACCESS_KEY=foo .

and you'd get

STEP 12/28: RUN scripts/enable_gcc8.sh

sudo apt-get install g++-8
Reading package lists...
Building dependency tree...
Reading state information...
The following additional packages will be installed:
  cpp-8 gcc-8 gcc-8-base libgcc-8-dev libmpx2 libstdc++-8-dev
Suggested packages:
  gcc-8-locales g++-8-multilib gcc-8-doc gcc-8-multilib libstdc++-8-doc
The following NEW packages will be installed:
  cpp-8 g++-8 gcc-8 gcc-8-base libgcc-8-dev libmpx2 libstdc++-8-dev
0 upgraded, 7 newly installed, 0 to remove and 0 not upgraded.
Need to get 32.8 MB of archives.
After this operation, 115 MB of additional disk space will be used.
Do you want to continue? [Y/n] Abort.
Error: building at STEP "RUN scripts/enable_gcc8.sh": while running runtime: exit status 1

It's possible to fix enable_gcc8.sh itself to avoid this error, but that script is actually not needed on Focal since gcc-9 is the default there.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from mabelzhang as a code owner September 14, 2023 15:10
@azeey azeey self-assigned this Sep 14, 2023
@azeey azeey added documentation Improvements or additions to documentation beta labels Sep 14, 2023
@azeey azeey merged commit 8561d33 into gazebosim:master Sep 18, 2023
2 checks passed
@azeey azeey deleted the remove_gcc8_focal branch September 18, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants