Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ignition #369

Merged
merged 6 commits into from
Nov 17, 2023
Merged

Remove ignition #369

merged 6 commits into from
Nov 17, 2023

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 28, 2023

🎉 New feature

Remove ignition

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@nkoenig
remove ignition
f968295 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig nkoenig marked this pull request as draft July 28, 2023 04:14
@nkoenig
fix build
19b796b 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@scpeters scpeters mentioned this pull request Jul 28, 2023
Merged
8 tasks
@scpeters
Copy link
Member

I found a few more things to remove, see #370 targeting this branch

@scpeters @j-rivero
Remove more deprecated ignition code
73dcbdc 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@j-rivero
Copy link
Contributor

j-rivero commented Oct 6, 2023

@osrf-jenkins run tests please

@j-rivero
Copy link
Contributor

j-rivero commented Oct 6, 2023

I found a few more things to remove, see #370 targeting this branch

Merged. Can we set this one to ready for review?

@mjcarroll mjcarroll marked this pull request as ready for review October 25, 2023 18:03
@mjcarroll
Merge branch 'main' into nkoenig/remove-ign
fbfc150 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@scpeters scpeters changed the title remove ignition Remove ignition Nov 17, 2023
scpeters
scpeters approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. we can update the migration guide later

@mjcarroll mjcarroll merged commit e9a97b1 into main Nov 17, 2023
4 of 6 checks passed
@mjcarroll mjcarroll deleted the nkoenig/remove-ign branch November 17, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@mjcarroll mjcarroll mjcarroll approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nkoenig @scpeters @j-rivero @mjcarroll