Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge gz-launch6 ➡️ gz-launch7 #251

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 4, 2024

➡️ Forward port

Port gz-launch6 ➡️ gz-launch7

Branch comparison: gz-launch7...gz-launch6

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
@azeey azeey requested a review from nkoenig as a code owner April 4, 2024 16:20
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 57.80%. Comparing base (28c76db) to head (3fb524c).

Files Patch % Lines
src/InstallationDirectories.cc 0.00% 4 Missing ⚠️
src/cmd/gz.cc 0.00% 2 Missing ⚠️
src/Manager.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           gz-launch7     #251      +/-   ##
==============================================
- Coverage       58.62%   57.80%   -0.82%     
==============================================
  Files               3        4       +1     
  Lines             423      429       +6     
==============================================
  Hits              248      248              
- Misses            175      181       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey
Copy link
Contributor Author

azeey commented Apr 4, 2024

Will wait for #252 to merge.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey merged commit 955dd77 into gazebosim:gz-launch7 Apr 8, 2024
7 of 10 checks passed
@azeey azeey deleted the 6_to_7 branch April 8, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants