Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix msvc loss of data warning #266

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

Blast545
Copy link
Contributor

@Blast545 Blast545 commented May 31, 2024

Summary

Attempt to fix the windows warning caused in the SimFactory code, reference:
https://build.osrfoundation.org/job/gz_launch-main-win/47/

It's complaining about an uint64 casted to protobuf::int32, so I think this PR should fix it. Don't fix it until checking win CI and validate if it actually fixes the problem.

cc: @Crola1702

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 self-assigned this May 31, 2024
@Blast545 Blast545 requested a review from nkoenig as a code owner May 31, 2024 05:33
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label May 31, 2024
@Blast545
Copy link
Contributor Author

For reference, this warning appeared in the last pr-win job, see: https://build.osrfoundation.org/job/gz_launch-pr-win/44/
So, if it doesn't happen in the pr-win CI of this job, this PR should be good to be merged.

@Blast545 Blast545 merged commit f0875c3 into main May 31, 2024
8 checks passed
@Blast545 Blast545 deleted the blast545/fix_win_warning_size branch May 31, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants