Fix plugin crash and update sim_plugins.gzlaunch #277
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
sim_plugins.gzlaunch
to use the latest gui plugins sinceGzScene3D
is no longer available. There's probably a smarter way to include all plugins from gz sim's gui.config. This is more of a patch to get things working.Known issue - gz launch now spins up gz sim and gui correctly but there is still an issue shutting down cleanly with Ctrl + C. I had to force kill the
gz-launch
process.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.