Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin crash and update sim_plugins.gzlaunch #277

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 6, 2024

🦟 Bug fix

Summary

  • Fixes crash when a plugin fails to load.
    • When joystick plugin fails to load (because there's no joystick device) the plugin gets deleted when it goes out of scope. This led to a crash. The workaround is to store the plugin and let gz launch destroy them when it exists.
  • Updated sim_plugins.gzlaunch to use the latest gui plugins since GzScene3D is no longer available. There's probably a smarter way to include all plugins from gz sim's gui.config. This is more of a patch to get things working.

Known issue - gz launch now spins up gz sim and gui correctly but there is still an issue shutting down cleanly with Ctrl + C. I had to force kill the gz-launch process.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@ahcorde ahcorde merged commit d8da500 into gz-launch8 Sep 6, 2024
11 checks passed
@ahcorde ahcorde deleted the launch_crash branch September 6, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants