Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to ignore local messages #506

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Jun 4, 2024

🎉 New feature

Adds a new option to ignore local messages (when publisher and subscriber share the same node).

Some context here .

Summary

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

caguero added 2 commits June 4, 2024 23:30
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit. I tested it with ros_gz_bridge and it seemed to work.

src/SubscribeOptions.cc Outdated Show resolved Hide resolved
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Carlos Agüero <cen.aguero@gmail.com>
@azeey azeey merged commit dc58e4a into gz-transport13 Jun 5, 2024
6 of 7 checks passed
@azeey azeey deleted the ignore_local_messages branch June 5, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants