fix: subject and summary should be allowed to have 1 char (#61)

gbprod · Mar 14, 2024 · 523a1a4 · 523a1a4
1 parent 2474065
commit 523a1a4
Show file tree

Hide file tree

Showing 5 changed files with 34,617 additions and 29,335 deletions.
diff --git a/corpus/body.txt b/corpus/body.txt
@@ -207,3 +207,16 @@ This is a simple body
   (message
     (overflow)))
 
+================================================================================
+Allows 1 char summary
+================================================================================
+This is a simple subject
+
+T
+--------------------------------------------------------------------------------
+
+(source
+  (subject)
+  (message))
+
+
diff --git a/corpus/subject.txt b/corpus/subject.txt
@@ -92,8 +92,9 @@ This should not exists
 --------------------------------------------------------------------------------
 
 (source
-    (subject)
-    (ERROR))
+  (ERROR
+    (subject))
+  (subject))
 
 ================================================================================
 Subject with type and scope
@@ -157,7 +158,7 @@ feat(issue42): allow numbers in scope
 
 (source
   (subject))
-  
+
 ================================================================================
 Parse fixup!
 ================================================================================
@@ -223,3 +224,13 @@ feat(hi)：some message
     (prefix
       (type)
       (scope))))
+
+================================================================================
+Allows 1 char subject
+================================================================================
+o
+
+--------------------------------------------------------------------------------
+
+(source
+  (subject))
diff --git a/grammar.js b/grammar.js
@@ -1,8 +1,8 @@
 const NEWLINE = /\r?\n/;
 const ANYTHING = /[^\n\r]+/;
-const SUBJECT = /[^\n\r]{1,49}/;
+const SUBJECT = /[^\n\r]{0,49}/;
 const NOT_A_COMMENT = /[^#]/;
-const SUMMARY = /[^\n\r]{1,72}/;
+const SUMMARY = /[^\n\r]{0,72}/;
 const SCISSORS = /# -+ >8 -+\r?\n/;
 const BRANCH_NAME = /[^\s'”»"“]+/;
 const COMMIT = /[0-9a-f]{7,40}/;

diff --git a/src/grammar.json b/src/grammar.json
@@ -149,7 +149,7 @@
                 },
                 {
                   "type": "PATTERN",
-                  "value": "[^\\n\\r]{1,49}"
+                  "value": "[^\\n\\r]{0,49}"
                 }
               ]
             },
@@ -289,7 +289,7 @@
             },
             {
               "type": "PATTERN",
-              "value": "[^\\n\\r]{1,72}"
+              "value": "[^\\n\\r]{0,72}"
             }
           ]
         },