Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable multithreading when seq_ends is passed as a tuple #113

Merged
merged 3 commits into from
Sep 29, 2024
Merged

Conversation

gdalle
Copy link
Owner

@gdalle gdalle commented Sep 29, 2024

This improves performance and type-stability for single-sequence routines by removing the overhead of @threads.

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.07%. Comparing base (d9e4a5d) to head (603def8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/inference/forward.jl 90.90% 1 Missing ⚠️
src/inference/forward_backward.jl 88.88% 1 Missing ⚠️
src/inference/viterbi.jl 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   89.77%   90.07%   +0.30%     
==========================================
  Files          17       17              
  Lines         489      504      +15     
==========================================
+ Hits          439      454      +15     
  Misses         50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as ready for review September 29, 2024 17:41
@gdalle gdalle merged commit 9802bad into main Sep 29, 2024
6 checks passed
@gdalle gdalle deleted the gd/nothreads branch September 29, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant