Added basic Hatch support #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzuillsmith
requested changes
Feb 18, 2019
| }); | ||
|
|
||
| it('should parse HATCH', function() { | ||
| verifyDxf |
There was a problem hiding this comment.
The new way to do this would be to just call verifyDxf(path.join(__dirname, 'data', 'hatch.dxf')); and the result will be suffixed with .received.json instead of .actual.json.
| // case 92: // Number of bytes in the proxy entity graphics represented in the subsequent 310 groups, which are binary chunk records (optional) | ||
| // This one is from common entity propierties | ||
| case 93: | ||
| var boundryVerticeCount = curr.value; |
There was a problem hiding this comment.
I think this should this be boundaryVertexCount.
|
Is there any update on this? It seems like only very minor changes to make it into master. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.