Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone: Fenaj Schedula Backend #40

Merged
merged 57 commits into from
Dec 14, 2023
Merged

Milestone: Fenaj Schedula Backend #40

merged 57 commits into from
Dec 14, 2023

Conversation

geekelo
Copy link
Owner

@geekelo geekelo commented Dec 11, 2023

IN This PR have implemented the Fenaj-Schedula Appointments Backend:🌐

  • Link to application front-end PR here
  • Link to application front-end source code here

NOTE

Requirements

  • All requirements can be found here

The following features were implemented in this project:

Ruby on Rails application

Database

  • Used PostGRES database with the following tables: users, items, reservations

API and endpoints

  • Set up routes, models, controllers and API endpoints for the following: User, Item, Reservation
  • More info on our API documentation can be found in /api-docs

Authentication

  • Set up authentication for API connections

Copy link

@Meltrust Meltrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!

To highlight:

  • Nice code organization ✔️
  • API is working well✔️
  • Good readme ✔️

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

You can do it

After implementing the requested changes, please submit another review request. ♻️

Check the comments under the review.

Cheers and Happy coding!👏👏👏

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.


@@ -0,0 +1,163 @@
<a name="readme-top"></a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Kindly, go to the frontend PR to check the review comments there.

@balatstar balatstar merged commit 0fa1dce into main Dec 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants