Merge pull request #25 from gemini-testing/HERMIONE-1399.rm_plugin

fix: remove hermione-image-minifier
gemini-testing · Feb 20, 2024 · ea5bb49 · ea5bb49
2 parents 886d913 + 84fc89f
commit ea5bb49
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 31 deletions.
diff --git a/docs/en/create-hermione-app.md b/docs/en/create-hermione-app.md
@@ -51,7 +51,6 @@ npm init hermione-app my-app -- --lang js
 - [Safari Commands](https://github.com/gemini-testing/hermione-safari-commands) - To add compatibility for safari mobile
 - [Test Repeater](https://github.com/gemini-testing/hermione-test-repeater) - To repeat tests the specified number of times regardless of the result
 - [Url Decorator](https://github.com/gemini-testing/url-decorator) - To add/replace url query params
-- [Image Minifier](https://github.com/gemini-testing/hermione-image-minifier) - To enable compression for reference images
 - [Reassert View](https://github.com/gemini-testing/hermione-reassert-view) - To make screenshot comparison by assertView less strict
 - [Storybook](https://github.com/gemini-testing/hermione-storybook) - To add ability to write hermione tests on storybook component and speed up their execution
 - [Html Reporter](https://github.com/gemini-testing/html-reporter) - To generate html-reports for showing passed/failed tests, screenshot diffs, error messages, stacktraces, meta-info and so on

diff --git a/docs/ru/create-hermione-app.md b/docs/ru/create-hermione-app.md
@@ -47,7 +47,6 @@ npm init hermione-app my-app -- --lang js
 - [Safari Commands](https://github.com/gemini-testing/hermione-safari-commands) - Чтобы поддержать работу для браузера `safari` на мобильных устройствах
 - [Test Repeater](https://github.com/gemini-testing/hermione-test-repeater) - Чтобы повторять тесты указанное количество раз вне зависимости от результата
 - [Url Decorator](https://github.com/gemini-testing/url-decorator) - Чтобы добавить/заменить параметры запроса в `url` команде
-- [Image Minifier](https://github.com/gemini-testing/hermione-image-minifier) - Чтобы сжимать эталонные изображения в скриншотном тестировании
 - [Reassert View](https://github.com/gemini-testing/hermione-reassert-view) - Чтобы сделать скриншотное тестирование менее строгим
 - [Storybook](https://github.com/gemini-testing/hermione-storybook) - Чтобы писать тесты на `storybook` компонентах и ускорить время их выполнения
 - [Html Reporter](https://github.com/gemini-testing/html-reporter) - Чтобы генерировать отчеты для отображения прошедших/упавших тестах, разницы между скриншотами, ошибкок, мета информации

diff --git a/src/constants/pluginGroups/reportsGroup.ts b/src/constants/pluginGroups/reportsGroup.ts
@@ -1,11 +1,5 @@
 import type { PluginGroup } from "../../types/toolOpts";
-import {
-    HERMIONE_IMAGE_MINIFIER,
-    HERMIONE_PLUGINS_PROFILER,
-    HERMIONE_PROFILER,
-    HERMIONE_STORYBOOK,
-    HTML_REPORTER,
-} from "../plugins";
+import { HERMIONE_PLUGINS_PROFILER, HERMIONE_PROFILER, HERMIONE_STORYBOOK, HTML_REPORTER } from "../plugins";
 
 const reportsGroup: PluginGroup = {
     description: "Generate reports about tests' results, plugins, their performance",
@@ -16,11 +10,6 @@ const reportsGroup: PluginGroup = {
             plugin: HTML_REPORTER,
             default: true,
         },
-        {
-            description: "Enable compression for reference images",
-            plugin: HERMIONE_IMAGE_MINIFIER,
-            default: false,
-        },
         {
             description: "Generate report about executed commands and their performance",
             plugin: HERMIONE_PROFILER,

diff --git a/src/constants/plugins.ts b/src/constants/plugins.ts
@@ -10,7 +10,6 @@ export const HERMIONE_HEADLESS_CHROME = "hermione-headless-chrome";
 export const URL_DECORATOR = "url-decorator";
 export const HERMIONE_TEST_FILTER = "hermione-test-filter";
 export const HERMIONE_OAUTH = "hermione-oauth";
-export const HERMIONE_IMAGE_MINIFIER = "hermione-image-minifier";
 export const HERMIONE_PLUGINS_PROFILER = "hermione-plugins-profiler";
 export const HERMIONE_TABS_CLOSER = "hermione-tabs-closer";
 export const HERMIONE_GLOBAL_HOOK = "hermione-global-hook";

diff --git a/src/pluginsConfig/hermione-image-minifier.ts b/src/pluginsConfig/hermione-image-minifier.ts
diff --git a/src/pluginsConfig/index.ts b/src/pluginsConfig/index.ts
@@ -13,7 +13,6 @@ import hermioneGlobalHook from "./hermione-global-hook";
 import hermioneTestRepeater from "./hermione-test-repeater";
 import hermioneRetryCommand from "./hermione-retry-command";
 import hermioneReassertView from "./hermione-reassert-view";
-import hermioneImageMinifier from "./hermione-image-minifier";
 import hermioneSafariCommands from "./hermione-safari-commands";
 import hermioneHeadlessChrome from "./hermione-headless-chrome";
 import hermionePluginsProfiler from "./hermione-plugins-profiler";
@@ -24,7 +23,6 @@ const pluginsConfig = [
     hermioneTestRepeater,
     hermioneRetryCommand,
     hermioneReassertView,
-    hermioneImageMinifier,
     hermionePluginsProfiler,
     hermioneTabsCloser,
     retryLimiter,