-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x11-misc/sddm: Outsource Gentoo defaults and resulting optional RDEPENDs to gui-apps/sddm-gentoo-config #267
base: master
Are you sure you want to change the base?
Conversation
39591a0
to
536ebb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - can we move sddm into this category too? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it and it's a UX improvement for when 0.20 lands. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We could also add support for |
It might be moved to |
|
||
RDEPEND=" | ||
X? ( x11-base/xorg-server ) | ||
!X? ( dev-libs/weston ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this instead be turned into || (weston kwin) ? that way there is no unnecessary dependency on weston if kwin is installed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is outdated. In ::gentoo these RDEPENDs are completely done away with and replaced by optfeature - since Wayland support is completely experimental anyway right now it will not gain automatic configuration via ebuild for the time being.
Is this still relevant/up to date? |
Eventually, it should become relevant, yes. |
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
SDDM may use xorg-server or weston as DisplayServer at runtime, since we can't have optional runtime dependencies, our newly created defaults config package will settle that. Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
cat <<-EOF >> "${T}"/01gentoo.conf | ||
[General] | ||
# Which display server should be used | ||
DisplayServer=$(usex X "x11" "wayland") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added DisplayServer="wayland"
to my config manually myself.
(WW) DAEMON: ""wayland"" is an invalid value for General.DisplayServer: fall back to "x11"
So the value may not have " "
in config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it won't - those are shell quotes that will be discarded while lexing the arguments to usex
methods, category and package name up for discussion.