Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x11-misc/sddm: Outsource Gentoo defaults and resulting optional RDEPENDs to gui-apps/sddm-gentoo-config #267

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

a17r
Copy link
Member

@a17r a17r commented Mar 22, 2023

methods, category and package name up for discussion.

@a17r a17r force-pushed the sddm-weston-vs-X branch 2 times, most recently from 39591a0 to 536ebb9 Compare March 22, 2023 20:33
Copy link
Member

@ArsenArsen ArsenArsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can we move sddm into this category too? :)

Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it and it's a UX improvement for when 0.20 lands. Thanks.

Copy link
Contributor

@Chiitoo Chiitoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@a17r
Copy link
Member Author

a17r commented Mar 29, 2023

We could also add support for x11-user setting, but I haven't looked at what it would entail. Suggestions for integrating IUSE-wise welcome.

@a17r
Copy link
Member Author

a17r commented May 21, 2023

LGTM - can we move sddm into this category too? :)

It might be moved to kde-plasma/ instead. https://invent.kde.org/plasma/plasma-desktop/-/issues/91


RDEPEND="
X? ( x11-base/xorg-server )
!X? ( dev-libs/weston )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this instead be turned into || (weston kwin) ? that way there is no unnecessary dependency on weston if kwin is installed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is outdated. In ::gentoo these RDEPENDs are completely done away with and replaced by optfeature - since Wayland support is completely experimental anyway right now it will not gain automatic configuration via ebuild for the time being.

@Chiitoo
Copy link
Contributor

Chiitoo commented Oct 27, 2023

Is this still relevant/up to date?

@a17r
Copy link
Member Author

a17r commented Nov 6, 2023

Eventually, it should become relevant, yes.

a17r added 3 commits March 8, 2024 23:27
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
SDDM may use xorg-server or weston as DisplayServer at runtime, since
we can't have optional runtime dependencies, our newly created defaults
config package will settle that.

Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
@a17r a17r force-pushed the sddm-weston-vs-X branch from 536ebb9 to d70ddb3 Compare March 8, 2024 22:30
cat <<-EOF >> "${T}"/01gentoo.conf
[General]
# Which display server should be used
DisplayServer=$(usex X "x11" "wayland")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added DisplayServer="wayland" to my config manually myself.
(WW) DAEMON: ""wayland"" is an invalid value for General.DisplayServer: fall back to "x11"
So the value may not have " " in config.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it won't - those are shell quotes that will be discarded while lexing the arguments to usex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants