Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo:
resolve_types
andcast
.GeometryArray::has_points
. I.e. bring back the slice offset and length. Then if the array has been sliced and the point array exists, check if the point values are within the bounds of the current slice. The fastest way to do this should be to check the length of the point array, then as you're iterating through the type_ids array, once you've seen that many ids pointing to the point array, you know the array is fully there. Or, in the cast of downcasting you really only care about whether any geometry exists. So you can short-circuit as soon as you've seen the first point.TryFrom
impl from GeometryArray toPointArray
, we need to call the slice when we export.Closes #416