Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release of 5.0.0 for willdurand/geocoder #1209

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Dec 21, 2023

Is there anything else we should add here?

geocoder-php/php-common@4.6.0...master

@Nyholm Nyholm requested a review from jbelien December 21, 2023 12:20
@jbelien
Copy link
Member

jbelien commented Dec 28, 2023

I'll investigate the checks that are failing on PHP 8.2 but the tests for BingMaps seems to fail only on PHP 8.3.

  1. Geocoder\Provider\BingMaps\Tests\BingMapsTest::testGeocodeWithRealAddressReturnsMultipleResults
    unserialize(): Extra data starting at offset 3984 of 3985 bytes

@Chris53897
Copy link
Contributor

@jbelien I guess it was wrong all the time and just popped up with PHP 8.3.
https://php.watch/versions/8.3/unserialize-E-WARNING

I did create a PR (see above) to solve this.
I am not sure if this is the best way. But i could not figure out where the LINE Carriage (i guess) at the File-End is created in the first place.

@jbelien
Copy link
Member

jbelien commented Mar 2, 2024

✅ We're back on track: #1220

@Nyholm
Copy link
Member Author

Nyholm commented Oct 7, 2024

I've rebased the PR.

@jbelien please merge if you think we are ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants