Add ability to auto-register GeoMesa File System DataStores #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Hughes <jnh5y@ccri.com>
elahrvivaz
reviewed
Dec 27, 2018
|
|
||
| override def doFilter(servletRequest: ServletRequest, servletResponse: ServletResponse, filterChain: FilterChain): Unit = { | ||
| val request = new Request() | ||
| request.setHttpRequest(servletRequest.asInstanceOf[HttpServletRequest]) |
There was a problem hiding this comment.
are these 2 lines doing anything? seems like they could be removed
elahrvivaz
reviewed
Dec 27, 2018
|
|
||
| def shouldCreate(workspace: String): Boolean = { | ||
| val base = System.getProperty("GEOMESA_FSDS_BASE_DIRECTORY") | ||
| if(base == null || Seq("styles", "web", "index.html", "openlayers3").contains(workspace)) return false |
There was a problem hiding this comment.
it might be safer to make these configurable in the spring bean, so that they can be configured. what are the typical url patterns you're matching here?
elahrvivaz
reviewed
Dec 27, 2018
| dsi.setEnabled(true) | ||
| dsi.setName(directory) | ||
|
|
||
| val factory = new FileSystemDataStoreFactory |
There was a problem hiding this comment.
what happens if you're not using the FSDS? is this going to break all other datastores?
elahrvivaz
reviewed
Dec 27, 2018
| val wsi = dti.getWorkspace | ||
|
|
||
| ds.getNames.foreach { name => | ||
| val fs = ds.getFeatureSource(name) |
There was a problem hiding this comment.
seems like this should check to see if the layers are already registered?
elahrvivaz
reviewed
Dec 27, 2018
| @@ -445,6 +445,12 @@ | |||
| <version>${slf4j.version}</version> | |||
| <scope>provided</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.specs2</groupId> | |||
| <artifactId>specs2_2.11</artifactId> | |||
There was a problem hiding this comment.
any chance for some unit tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jim Hughes jnh5y@ccri.com