Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capture dct:spatial as bbox, if it contains a box #963

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pvgenuchten
Copy link
Contributor

in some cases, bbox is strored in dct:spatial, nice to have it as bbox

added some csw parse tests, seemed not existing

@coveralls
Copy link

Coverage Status

coverage: 60.296% (+1.3%) from 58.984%
when pulling e81b2e5 on pvgenuchten:if_dct_spatial_has_a_box
into 1354d06 on geopython:master.

@geographika
Copy link
Contributor

@pvgenuchten - great to get some tests for the CSW parsing. It looks like there is a lot of shared code in the __init__ for CswRecord and Csw30Record that could be refactored into one function - maybe for another pull request.

A couple of questions:

  1. If a document has both ows:BoundingBox and dct:spatial then self.bbox will overwrite the value from ows:BoundingBox with dct:spatial. Is this scenario possible, and if yes then should this be the correct precedence?
  2. If dct:spatial is not a bbox in the form -180,-90,180,90 then self.spatial is set to val. What could val be - a string? It would be good to have an example document and test for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants