Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show QR with lowercase invoice value #3196

Closed
wants to merge 1 commit into from

Conversation

im-adithya
Copy link
Member

Describe the changes you have made in this PR

From unes on Telegram:

when generating an invoice using the extension then scan the qr code using a mobile app or a centralized exchange the invoice url is in uppercase and some apps does not allow this

Is there any reason why we use toUpperCase()?

Type of change

(Remove other not matching type)

  • fix: Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Manually

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable
  • Update Docs & Guides
  • For UI-related changes
  • Darkmode
  • Responsive layout

@im-adithya
Copy link
Member Author

Sorry for opening this. QRs should always have BOLT-11 in upper case. See requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants