Document crate-type lib requirement for generate-sources #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- previously crate-type lib seemed optional - fixes getditto#173
kriswuollett
force-pushed
the
update-crate-type-docs
branch
from
5fca7a8
to
6d28480
Compare
| @@ -60,7 +60,7 @@ edition = "2021" | |||
| crate-type = [ | |||
| "staticlib", # Ensure it gets compiled as a (static) C library | |||
| # "cdylib", # If you want a shared/dynamic C library (advanced) | |||
| "lib", # For downstream Rust dependents: `examples/`, `tests/` etc. | |||
There was a problem hiding this comment.
Nice to get it properly documented 🙏 although I do like the mention of downstream rust dependents as well, so I'd like to keep it.
What about:
"lib", # For `generate-headers` and other downstream rust dependents
# such as integration `tests/`, doctests, and `examples/`There was a problem hiding this comment.
Nice to get it properly documented 🙏 although I do like the mention of downstream rust dependents as well, so I'd like to keep it.
What about:
"lib", # For `generate-headers` and other downstream rust dependents # such as integration `tests/`, doctests, and `examples/`
Sure, took your suggestion verbatim.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crate-typelibseems documented too optional #173