E2e tests fixes after 0.19 updates #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -276,8 +276,8 @@ def init(ctx, kfp_url: str, with_github_actions: bool): | |||
| context_helper = ctx.obj["context_helper"] | |||
| project_name = context_helper.context.project_path.name | |||
| if with_github_actions: | |||
| image = f"gcr.io/${{google_project_id}}/{project_name}:${{commit_id}}" | |||
| run_name = f"{project_name}:${{commit_id}}" | |||
| image = f"gcr.io/${{oc.env:KEDRO_CONFIG_GOOGLE_PROJECT_ID}}/{project_name}:${{oc.env:KEDRO_CONFIG_COMMIT_ID, unknown-commit}}" # noqa: E501 | |||
There was a problem hiding this comment.
@Lasica Shouldn't this be just oc.env:google_project_id as we are replacing the env variable's prefix and converting to lowercase here ?
Further reference: kedro-kubeflow doc
There was a problem hiding this comment.
It used to be the case, now it's a bit irrelevant. It should work in the way I specified with the env variables provided. In general I want to remove and deprecate EnvTemplatedConfigLoader and replace it with recommendations to use oc.env directly.
Lasica
changed the title
Lasica
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
describe the purpose of the change hereResolves
<issue nr here>PR Checklist