-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue unmarshalling when discriminator field is set in openapi2.0 #1011
base: master
Are you sure you want to change the base?
Conversation
8e92e88
to
e17e91d
Compare
@fenollp can please review this PR? Thanks |
Hi! Thanks for tackling this. The ideal solution to me is to define a different Discriminator type in v2 and leave the current definition as is in v3. I. E. to have two different types and avoid casting. |
e6db200
to
2e539ed
Compare
34c2229
to
b0f93cc
Compare
Hi @fenollp, thank you for your feedback. I agree with your suggestion. After looking into the proposed approach, it seemed like it would involve significant effort to refactor. I’ve updated the PR with a simpler approach than before to address the bug. Please review and let me know what you think. I can look into implementing the suggested approach without any strict time constraints in a different PR if its still required after this PR. |
This PR addresses issue #1010. It allows
discriminator
field to be of any type and case it based on the OpenAPI version.