Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue unmarshalling when discriminator field is set in openapi2.0 #1011

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

reversearrow
Copy link
Contributor

This PR addresses issue #1010. It allows discriminator field to be of any type and case it based on the OpenAPI version.

@reversearrow reversearrow marked this pull request as draft September 17, 2024 15:58
@reversearrow reversearrow marked this pull request as ready for review September 17, 2024 16:07
@reversearrow reversearrow marked this pull request as draft September 17, 2024 16:07
@reversearrow reversearrow marked this pull request as ready for review September 17, 2024 16:37
@reversearrow
Copy link
Contributor Author

@fenollp can please review this PR? Thanks

@fenollp
Copy link
Collaborator

fenollp commented Sep 19, 2024

Hi! Thanks for tackling this.

The ideal solution to me is to define a different Discriminator type in v2 and leave the current definition as is in v3. I. E. to have two different types and avoid casting.
Do you think you'd be able to update your PR with this in mind?
Thanks

@fenollp fenollp linked an issue Sep 19, 2024 that may be closed by this pull request
@reversearrow
Copy link
Contributor Author

reversearrow commented Sep 23, 2024

Hi! Thanks for tackling this.

The ideal solution to me is to define a different Discriminator type in v2 and leave the current definition as is in v3. I. E. to have two different types and avoid casting. Do you think you'd be able to update your PR with this in mind? Thanks

Hi @fenollp, thank you for your feedback. I agree with your suggestion. After looking into the proposed approach, it seemed like it would involve significant effort to refactor. I’ve updated the PR with a simpler approach than before to address the bug. Please review and let me know what you think. I can look into implementing the suggested approach without any strict time constraints in a different PR if its still required after this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAPI 2.0: Unable to Unmarshal Spec with Discriminator Field Set
2 participants