Adding SNI to peer certificate verification #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coveralls is failing but tests are passing |
|
Not sure why coveralls is returning 405, but let's just ignore that for now. Merge away! Could you open a PR to update this in Flashlight? You can just merge it straight away. |
|
Looks like they're down: https://status.coveralls.io/ |
…e received verifyHost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this pull request I'm adding a
VerifyHostattribute that shall be used when verifying peer certificates from requests that use the SNI config. Some unit tests were added, some updated with the new parameter and some deprecated libraries fromcache.gohave been replaced.