Skip to content

Commit

Permalink
Merge pull request #313 from MarcEspiard/add-webp-and-avif-exception-…
Browse files Browse the repository at this point in the history
…to-request-function

Add webp and avif exceptions to CF request function
  • Loading branch information
fredericbarthelet authored Mar 3, 2023
2 parents 96c8b37 + e55c4dd commit de59ab3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/constructs/aws/SinglePageApp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ export class SinglePageApp extends StaticWebsiteAbstract {
* let static files pass.
*
* Files extensions list taken from: https://docs.aws.amazon.com/amplify/latest/userguide/redirects.html#redirects-for-single-page-web-apps-spa
* Add pdf, xml and webmanifest as well
* Add pdf, xml, webmanifest and avif as well
*/
const code = `var REDIRECT_REGEX = /^[^.]+$|\\.(?!(css|gif|ico|jpg|jpeg|js|png|txt|svg|woff|woff2|ttf|map|json|xml|pdf|webmanifest)$)([^.]+$)/;
const code = `var REDIRECT_REGEX = /^[^.]+$|\\.(?!(css|gif|ico|jpg|jpeg|js|png|txt|svg|woff|woff2|ttf|map|json|webp|xml|pdf|webmanifest|avif)$)([^.]+$)/;
function handler(event) {
var uri = event.request.uri;
Expand Down
4 changes: 2 additions & 2 deletions test/unit/singlePageApp.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe("single page app", () => {
Object {
"Properties": Object {
"AutoPublish": true,
"FunctionCode": "var REDIRECT_REGEX = /^[^.]+$|\\\\.(?!(css|gif|ico|jpg|jpeg|js|png|txt|svg|woff|woff2|ttf|map|json|xml|pdf|webmanifest)$)([^.]+$)/;
"FunctionCode": "var REDIRECT_REGEX = /^[^.]+$|\\\\.(?!(css|gif|ico|jpg|jpeg|js|png|txt|svg|woff|woff2|ttf|map|json|webp|xml|pdf|webmanifest|avif)$)([^.]+$)/;
function handler(event) {
var uri = event.request.uri;
Expand Down Expand Up @@ -99,7 +99,7 @@ describe("single page app", () => {
});
const requestFunction = computeLogicalId("landing", "RequestFunction");
expect(cfTemplate.Resources[requestFunction].Properties.FunctionCode).toMatchInlineSnapshot(`
"var REDIRECT_REGEX = /^[^.]+$|\\\\.(?!(css|gif|ico|jpg|jpeg|js|png|txt|svg|woff|woff2|ttf|map|json|xml|pdf|webmanifest)$)([^.]+$)/;
"var REDIRECT_REGEX = /^[^.]+$|\\\\.(?!(css|gif|ico|jpg|jpeg|js|png|txt|svg|woff|woff2|ttf|map|json|webp|xml|pdf|webmanifest|avif)$)([^.]+$)/;
function handler(event) {
var uri = event.request.uri;
Expand Down

0 comments on commit de59ab3

Please sign in to comment.