fix: use window.location.origin as baseUrl for scrapeList

[amhsirak]

fixes #227

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of relative URLs for src and href attributes during scraping, ensuring accurate URL resolution against the current window origin.

• Style

  • Minor formatting adjustments for improved code readability, including the removal of unnecessary comments and added whitespace.

[coderabbitai]

Walkthrough

The changes in this pull request primarily involve updates to the scrapeList function in scraper.js, focusing on the handling of relative URLs. The implementation has shifted from using a variable named baseUrl to utilizing window.location.origin for constructing URLs. This adjustment aims to improve the accuracy of URL resolution when scraping DOM elements. Minor formatting changes were also made, including the removal of comments and enhanced whitespace for readability.

Changes

File Path	Change Summary
maxun-core/src/browserSide/scraper.js	Updated scrapeList function to use window.location.origin for relative URLs; removed unnecessary comments and improved formatting.

Assessment against linked issues

Objective	Addressed	Explanation
ReferenceError: baseUrl is not defined in Capture list (#227)	✅

Poem

In the world of code, I hop and play,
Fixing bugs, making URLs sway.
With window.location, I found my way,
Scraping with joy, come what may!
A cleaner path, oh what a delight,
Happy coding, from morning to night! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[amhsirak]

Works correctly for a run.
Issue persists during output preview

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

maxun-core/src/browserSide/scraper.js (2)

286-288: Add error handling for malformed URLs

The URL resolution is correctly implemented, but consider adding try-catch block to handle malformed URLs gracefully.

 // Handle relative 'src' URLs
 const src = fieldElement.getAttribute('src');
-record[label] = src ? new URL(src, window.location.origin).href : null;
+record[label] = src ? (() => {
+  try {
+    return new URL(src, window.location.origin).href;
+  } catch (e) {
+    console.warn(`Invalid URL found for ${label}: ${src}`);
+    return null;
+  }
+})() : null;

---

292-292: Reduce code duplication in URL handling

The URL resolution logic is duplicated between 'src' and 'href' handling. Consider extracting it into a helper function.

+const resolveRelativeUrl = (url, label) => {
+  if (!url) return null;
+  try {
+    return new URL(url, window.location.origin).href;
+  } catch (e) {
+    console.warn(`Invalid URL found for ${label}: ${url}`);
+    return null;
+  }
+};

 // In the scrapeList function:
-record[label] = src ? new URL(src, window.location.origin).href : null;
+record[label] = resolveRelativeUrl(src, label);

-record[label] = href ? new URL(href, window.location.origin).href : null;
+record[label] = resolveRelativeUrl(href, label);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 236f3ed and 429ddaa.

📒 Files selected for processing (1)

• maxun-core/src/browserSide/scraper.js (2 hunks)

🔇 Additional comments (1)

maxun-core/src/browserSide/scraper.js (1)

286-288: LGTM! Changes successfully address the baseUrl ReferenceError

The implementation correctly uses window.location.origin for URL resolution, effectively fixing the undefined baseUrl reference issue. The solution is robust and follows web standards for URL handling.

Also applies to: 292-292